AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[js-perf-test] add microbenchmarks for (Object|Reflect).getOwnPropertyDescriptor

Browse Source 
Based on the robust test suite for checking property "has/in" queries, with the intention
of measuring the performance of accessing getOwnPropertyDescriptor.

Background: getOwnPropertyDescriptor and defineProperty were identified as hot code taking up
a significant chunk of startup time in a customer application. This benchmark aims to measure
the difference made by a modifying Object.getOwnPropertyDescriptor.

By current measurements, the geometric mean time of the new version is typically 1/6 that of
the current upstream implementation, using this test specifically (however, only on arm64 /
Apple M1... On Linux/x64, the results look more reasonable at a roughly 5-12% improvement in
score).

In its current form, this benchmark does very little to attempt to verify the results of the
object, which may result in branches being discarded in Turbofan (but given the enormous
difference between x64 and arm64, I'm not positive this is what is happening, and have not yet
verified this).

BUG=

Change-Id: I0f10735315313ed97efd00fcccaedc1272d4d314
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3624979
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80373}
This commit is contained in:
Caitlin Potter 2022-05-03 14:34:02 -04:00 committed by V8 LUCI CQ
parent 82339990dc
commit 190128ce7c
3 changed files with 389 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
test/js-perf-test/GetOwnPropertyDescriptor/GetOwnPropertyDescriptor.json Normal file
View File

@ -0,0 +1,85 @@
{
"name": "GetOwnPropertyDescriptorTests",
"run_count": 5,
"run_count_android_arm": 3,
"run_count_android_arm64": 3,
"timeout": 300,
"units": "score",
"total": true,
"owners": ["caitp"],
"resources": ["base.js"],
"tests": [
{
"name": "GetOwnPropertyDescriptor",
"path": ["."],
"main": "run.js",
"flags": [""],
"resources": [
"get-own-property-descriptor.js"
],
"results_regexp": "^%s\\-GetOwnPropertyDescriptor\\(Score\\): (.+)$",
"tests": [
{"name": "ObjectGetOwnPropertyDescriptor--object--INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--object--DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--object--NE-INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--object--NE-DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--object--el"},
{"name": "ObjectGetOwnPropertyDescriptor--object--NE-el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-no-trap--INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-no-trap--DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-no-trap--NE-INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-no-trap--NE-DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-no-trap--el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-no-trap--NE-el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-reflect--INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-reflect--DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-reflect--NE-INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-reflect--NE-DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-reflect--el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-reflect--NE-el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-no-trap--INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-no-trap--DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-no-trap--NE-INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-no-trap--NE-DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-no-trap--el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-no-trap--NE-el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-reflect--INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-reflect--DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-reflect--NE-INTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-reflect--NE-DEINTERN-prop"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-reflect--el"},
{"name": "ObjectGetOwnPropertyDescriptor--proxy-proxy-reflect--NE-el"},
{"name": "ReflectGetOwnPropertyDescriptor--object--INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--object--DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--object--NE-INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--object--NE-DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--object--el"},
{"name": "ReflectGetOwnPropertyDescriptor--object--NE-el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-no-trap--INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-no-trap--DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-no-trap--NE-INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-no-trap--NE-DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-no-trap--el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-no-trap--NE-el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-reflect--INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-reflect--DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-reflect--NE-INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-reflect--NE-DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-reflect--el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-reflect--NE-el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-no-trap--INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-no-trap--DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-no-trap--NE-INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-no-trap--NE-DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-no-trap--el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-no-trap--NE-el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-reflect--INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-reflect--DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-reflect--NE-INTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-reflect--NE-DEINTERN-prop"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-reflect--el"},
{"name": "ReflectGetOwnPropertyDescriptor--proxy-proxy-reflect--NE-el"}
]
}
]
}

280
test/js-perf-test/GetOwnPropertyDescriptor/get-own-property-descriptor.js Normal file
View File

@ -0,0 +1,280 @@
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
function ObjectWithKeys(count, keyOffset = 0, keyGen) {
var body = "";
for (var i = 0; i < count; i++) {
var key = keyGen(i + keyOffset);
if (typeof key === "string") {
body += `this.${key} = 0\n`;
} else {
body += `this[${key}] = 0\n`;
}
}
var f = new Function(body);
return new f();
}
function ObjectWithProperties(count, keyOffset) {
return ObjectWithKeys(count, keyOffset, (key) => "key" + key );
}
function ObjectWithElements(count, keyOffset) {
return ObjectWithKeys(count, keyOffset, (key) => key );
}
function ObjectWithMixedKeys(count, keyOffset) {
return ObjectWithKeys(count, keyOffset, (key) => {
if (key % 2 == 0) return (key / 2);
return "key" + ((key - 1) / 2);
});
}
// Create an object with 0 prototypes each having #keys properties
// generated by given keyGen.
function ObjectWithOwnKeys(depth, keys,
keyGen = ObjectWithProperties) {
var o = keyGen(keys);
var current = o;
var keyOffset = 0;
for (var i = 0; i < 1; i++) {
keyOffset += keys;
current.__proto__ = keyGen(keys, keyOffset);
}
return o;
}
function HoleyIntArray(size) {
var array = new Array(size);
for (var i = 0; i < size; i += 3) {
array[i] = i;
}
return array
}
function IntArray(size) {
var array = new Array(size);
for (var i = 0; i < size; i++) {
array[i] = i;
}
return array;
}
// Switch object's properties and elements to dictionary mode.
function MakeDictionaryMode(obj) {
obj.foo = 0;
obj.bar = 0;
// Delete the second-to-last property first to force normalization.
delete obj.foo;
delete obj.bar;
obj[1e9] = 0;
return obj;
}
function Internalize(s) {
return Object.keys({[s]:0})[0];
}
function Deinternalize(s) {
return [...s].join("");
}
// ============================================================================
const QUERY_INTERNALIZED_PROP = "INTERN-prop";
const QUERY_DEINTERNALIZED_PROP = "DEINTERN-prop";
const QUERY_NON_EXISTING_INTERNALIZED_PROP = "NE-INTERN-prop";
const QUERY_NON_EXISTING_DEINTERNALIZED_PROP = "NE-DEINTERN-prop";
const QUERY_ELEMENT = "el";
const QUERY_NON_EXISTING_ELEMENT = "NE-el";
const OBJ_MODE_FAST = "fast";
const OBJ_MODE_SLOW = "slow";
var TestQueries = [
QUERY_INTERNALIZED_PROP,
QUERY_DEINTERNALIZED_PROP,
QUERY_NON_EXISTING_INTERNALIZED_PROP,
QUERY_NON_EXISTING_DEINTERNALIZED_PROP,
QUERY_ELEMENT,
QUERY_NON_EXISTING_ELEMENT,
];
const QUERIES_PER_OBJECT_NUMBER = 10;
// Leave only every "count"th keys.
function FilterKeys(keys, count) {
var len = keys.length;
if (len < count) throw new Error("Keys array is too short: " + len);
var step = len / count;
if (step == 0) throw new Error("Bad count specified: " + count);
return keys.filter((element, index) => index % step == 0);
}
function MakeKeyQueries(keys, query_kind) {
var properties = keys.filter((element) => isNaN(Number(element)));
var elements = keys.filter((element) => !isNaN(Number(element)));
properties = FilterKeys(properties, QUERIES_PER_OBJECT_NUMBER);
elements = FilterKeys(elements, QUERIES_PER_OBJECT_NUMBER);
switch (query_kind) {
case QUERY_INTERNALIZED_PROP:
return properties;
case QUERY_DEINTERNALIZED_PROP:
return properties.map(Deinternalize);
case QUERY_NON_EXISTING_INTERNALIZED_PROP:
case QUERY_NON_EXISTING_DEINTERNALIZED_PROP:
var non_existing = [];
for (var i = 0; i < QUERIES_PER_OBJECT_NUMBER; i++) {
non_existing.push("non-existing" + i);
}
if (query_kind == QUERY_NON_EXISTING_INTERNALIZED_PROP) {
return non_existing.map(Internalize);
} else {
return non_existing.map(Deinternalize);
}
case QUERY_ELEMENT:
return elements.map(Number);
case QUERY_NON_EXISTING_ELEMENT:
var non_existing = [];
for (var i = 0; i < QUERIES_PER_OBJECT_NUMBER; i++) {
non_existing.push(1200 + 100*i);
}
return non_existing;
default:
throw new Error("Bad query_kind: " + query_kind);
}
}
var TestData = [];
[OBJ_MODE_FAST, OBJ_MODE_SLOW].forEach((obj_mode) => {
var name = `${obj_mode}-obj`;
var objects = [];
[10, 50, 100, 200, 500].forEach((prop_count) => {
// Create object with prop_count properties and prop_count elements.
obj = ObjectWithOwnKeys(5, prop_count * 2, ObjectWithMixedKeys);
if (obj_mode == OBJ_MODE_SLOW) {
obj = MakeDictionaryMode(obj);
}
objects.push(obj);
});
TestData.push({name, objects});
});
// ============================================================================
function CreateTestFunction(testMethod, object, keys) {
// Force a new function for each test-object to avoid side-effects due to ICs.
var text = `
// random comment ${Math.random()}
let results = [];
for (var key in keys) {
results.push(${testMethod}(object, key));
}
return results;`;
var func = new Function("object", "keys", text);
return () => func(object, keys);
}
function CombineTestFunctions(tests) {
return () => {
for (var i = 0; i < tests.length; i++ ) {
let results = tests[i]();
results.push(1);
globalThis.results = results;
}
};
}
var TestMethods = {
"ObjectGetOwnPropertyDescriptor": "Object.getOwnPropertyDescriptor",
"ReflectGetOwnPropertyDescriptor": "Reflect.getOwnPropertyDescriptor",
};
var TestTargets = {
"object": {
target(object) {
return object;
}
},
"proxy-no-trap": {
target(object) {
return new Proxy(object, {});
},
},
"proxy-reflect": {
target(object) {
return new Proxy(object, {
getOwnPropertyDescriptor(target, propertyKey) {
return Reflect.getOwnPropertyDescriptor(target, propertyKey);
}
});
}
},
"proxy-proxy-no-trap": {
target(object) {
let proxy = this["proxy-no-trap"].target(object);
return new Proxy(proxy, {});
}
},
"proxy-proxy-reflect": {
target(object) {
let proxy = this["proxy-no-trap"].target(object);
return new Proxy(object, {
getOwnPropertyDescriptor(target, propertyKey) {
return Reflect.getOwnPropertyDescriptor(target, propertyKey);
}
});
}
}
};
// ============================================================================
// Create the benchmark suites. We create a suite for each pair of the test
// functions above and query kind. Each suite contains benchmarks for each
// object type.
var Benchmarks = [];
for (var [test_method_name, test_method_entry] of Object.entries(TestMethods)) {
for (var [test_target_name, test_target] of Object.entries(TestTargets)) {
for (var query_kind of TestQueries) {
var benchmarks = [];
var suit_name = `${test_method_name}--${test_target_name}--${query_kind}`;
for (var test_data of TestData) {
var name = `${suit_name}--${test_data.name}`;
var tests = [];
for (var object of test_data.objects) {
var keys = Object.getOwnPropertyNames(object);
keys = MakeKeyQueries(keys, query_kind);
var test = CreateTestFunction(test_method_entry, object, keys);
tests.push(test);
}
var run_function = CombineTestFunctions(tests);
var benchmark = new Benchmark(name, false, false, 0, run_function);
benchmarks.push(benchmark);
}
Benchmarks.push(new BenchmarkSuite(suit_name, [100], benchmarks));
}
}
}
// ============================================================================

24
test/js-perf-test/GetOwnPropertyDescriptor/run.js Normal file
View File

@ -0,0 +1,24 @@
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
d8.file.execute('../base.js');
d8.file.execute('get-own-property-descriptor.js');
function PrintResult(name, result) {
print(`${name}-GetOwnPropertyDescriptor(Score): ${result}`);
}
function PrintStep(name) {}
function PrintError(name, error) {
PrintResult(name, error);
}
BenchmarkSuite.config.doWarmup = undefined;
BenchmarkSuite.config.doDeterministic = undefined;
BenchmarkSuite.RunSuites({ NotifyResult: PrintResult,
NotifyError: PrintError,
NotifyStep: PrintStep });