AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove harmony-atomics flag and collapse it into sharedarraybuffer flag

Browse Source 
Having both flags is tedious, and it is unlikely you'd ever want them
separately.

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/1304163010

Cr-Commit-Position: refs/heads/master@{#30523}
This commit is contained in:
binji 2015-09-01 11:33:51 -07:00 committed by Commit bot
parent 6184f1fef6
commit 196d6aeec1
16 changed files with 15 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/bootstrapper.cc
View File

@ -1845,7 +1845,6 @@ EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_destructuring)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_object)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_object_observe)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_spread_arrays)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_atomics)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_new_target)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_concat_spreadable)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_regexps)
@ -2491,9 +2490,7 @@ bool Genesis::InstallExperimentalNatives() {
"native harmony-object-observe.js", nullptr};
static const char* harmony_spread_arrays_natives[] = {nullptr};
static const char* harmony_sharedarraybuffer_natives[] = {
"native harmony-sharedarraybuffer.js", NULL};
static const char* harmony_atomics_natives[] = {"native harmony-atomics.js",
nullptr};
"native harmony-sharedarraybuffer.js", "native harmony-atomics.js", NULL};
static const char* harmony_new_target_natives[] = {nullptr};
static const char* harmony_concat_spreadable_natives[] = {
"native harmony-concat-spreadable.js", nullptr};
@ -2610,7 +2607,7 @@ void Genesis::InstallBuiltinFunctionIds() {
void Genesis::InstallExperimentalBuiltinFunctionIds() {
if (FLAG_harmony_atomics) {
if (FLAG_harmony_sharedarraybuffer) {
struct BuiltinFunctionIds {
const char* holder_expr;
const char* fun_name;

1
src/flag-definitions.h
View File

@ -199,7 +199,6 @@ DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode")
V(harmony_destructuring, "harmony destructuring") \
V(harmony_default_parameters, "harmony default parameters") \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
V(harmony_simd, "harmony simd")
// Features that are complete (but still behind --harmony/es-staging flag).

1
test/cctest/test-api.cc
View File

@ -21835,7 +21835,6 @@ class FutexInterruptionThread : public v8::base::Thread {
TEST(FutexInterruption) {
i::FLAG_harmony_sharedarraybuffer = true;
i::FLAG_harmony_atomics = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
LocalContext env;

2
test/mjsunit/asm/atomics-add.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-and.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-compareexchange.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-exchange.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-load.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-or.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-store.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-sub.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/asm/atomics-xor.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) {
"use asm";

2
test/mjsunit/d8-worker-sharedarraybuffer.js
View File

@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --harmony-sharedarraybuffer --harmony-atomics
// Flags: --harmony-sharedarraybuffer
if (this.Worker) {

2
test/mjsunit/harmony/atomics.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer
// Flags: --harmony-sharedarraybuffer
//
function toRangeWrapped(value) {

2
test/mjsunit/harmony/futex.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --harmony-atomics --harmony-sharedarraybuffer
// Flags: --allow-natives-syntax --harmony-sharedarraybuffer
(function TestFailsWithNonSharedArray() {
var ab = new ArrayBuffer(16);

2
test/mjsunit/regress/regress-crbug-501809.js
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-sharedarraybuffer --harmony-atomics
// Flags: --harmony-sharedarraybuffer
var sab = new SharedArrayBuffer(8);
var ta = new Int32Array(sab);
ta.__defineSetter__('length', function() {;});