AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Interpreter] Use FastCloneRegExpStub for CreateRegExpLiteral.

Browse Source 
No need to go to the runtime to create a RegExp literal in Ignition, the
stub can handle everything.

R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/1737633002

Cr-Commit-Position: refs/heads/master@{#34292}
This commit is contained in:
bmeurer 2016-02-25 05:32:20 -08:00 committed by Commit bot
parent 9d0d5fd20d
commit 19bad8a9f1
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/interpreter/interpreter.cc
View File

@ -1573,7 +1573,20 @@ void Interpreter::DoCreateLiteral(Runtime::FunctionId function_id,
// Creates a regular expression literal for literal index <literal_idx> with
// <flags> and the pattern in <pattern_idx>.
void Interpreter::DoCreateRegExpLiteral(InterpreterAssembler* assembler) {
DoCreateLiteral(Runtime::kCreateRegExpLiteral, assembler);
Callable callable = CodeFactory::FastCloneRegExp(isolate_);
Node* target = __ HeapConstant(callable.code());
Node* index = __ BytecodeOperandIdx(0);
Node* pattern = __ LoadConstantPoolEntry(index);
Node* literal_index_raw = __ BytecodeOperandIdx(1);
Node* literal_index = __ SmiTag(literal_index_raw);
Node* flags_raw = __ BytecodeOperandImm(2);
Node* flags = __ SmiTag(flags_raw);
Node* closure = __ LoadRegister(Register::function_closure());
Node* context = __ GetContext();
Node* result = __ CallStub(callable.descriptor(), target, context, closure,
literal_index, pattern, flags);
__ SetAccumulator(result);
__ Dispatch();
}
@ -1582,7 +1595,7 @@ void Interpreter::DoCreateRegExpLiteral(InterpreterAssembler* assembler) {
// Creates a regular expression literal for literal index <literal_idx> with
// <flags> and the pattern in <pattern_idx>.
void Interpreter::DoCreateRegExpLiteralWide(InterpreterAssembler* assembler) {
DoCreateLiteral(Runtime::kCreateRegExpLiteral, assembler);
DoCreateRegExpLiteral(assembler);
}