AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[tools] return early in fetch_deps.py.

Browse Source 
TBR=machenbach@chromium.org

Bug: v8:6105
Change-Id: I15fe26c8546e024794c165affd17ce104ecae4a1
Reviewed-on: https://chromium-review.googlesource.com/867870
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50616}
This commit is contained in:
Yang Guo 2018-01-16 12:02:32 +01:00 committed by Commit Bot
parent d53c4aa065
commit 1a0cc926ba
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/node/fetch_deps.py
View File

@ -61,6 +61,12 @@ def EnsureGit(v8_path):
return True
def FetchDeps(v8_path):
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
# Verify path.
v8_path = os.path.abspath(v8_path)
assert os.path.isdir(v8_path)
@ -89,11 +95,6 @@ def FetchDeps(v8_path):
if os.path.isfile(gclient_entries):
os.remove(gclient_entries)
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
if __name__ == "__main__":
FetchDeps(sys.argv[1])