AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[maglev][arm64] Fix cloberred register in ReduceInterruptBudget

Browse Source 
Bug: v8:7700
Change-Id: I883de6edfd218cfff23a4b4a512c516cb825734c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4161766
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85256}
This commit is contained in:
Victor Gomes 2023-01-12 15:23:26 +01:00 committed by V8 LUCI CQ
parent 90c972bb52
commit 1a109d28a5
1 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/maglev/arm64/maglev-ir-arm64.cc
View File

@ -1792,20 +1792,25 @@ void HandleInterruptsAndTiering(MaglevAssembler* masm, ZoneLabelRef done,
__ B(*done);
__ Bind(&update_profiler_ticks_and_interrupt_budget);
// We are skipping the call to Runtime::kBytecodeBudgetInterrupt_Maglev
// since the tiering state is kInProgress. Perform bookkeeping that would
// have been done in the runtime function:
__ AssertFeedbackVector(scratch0);
// FeedbackVector::SaturatingIncrementProfilerTicks.
// TODO(jgruber): This isn't saturating and thus we may theoretically
// exceed Smi::kMaxValue. But, 1) this is very unlikely since it'd take
// quite some time to exhaust the budget that many times; and 2) even an
// overflow doesn't hurt us at all.
__ Ldr(scratch0.W(),
FieldMemOperand(scratch0, FeedbackVector::kProfilerTicksOffset));
__ Add(scratch0.W(), scratch0.W(), Immediate(1));
__ Str(scratch0.W(),
FieldMemOperand(scratch0, FeedbackVector::kProfilerTicksOffset));
{
UseScratchRegisterScope temps(masm);
Register feedback_vector = scratch0;
Register ticks = temps.AcquireW();
// We are skipping the call to Runtime::kBytecodeBudgetInterrupt_Maglev
// since the tiering state is kInProgress. Perform bookkeeping that would
// have been done in the runtime function:
__ AssertFeedbackVector(feedback_vector);
// FeedbackVector::SaturatingIncrementProfilerTicks.
// TODO(jgruber): This isn't saturating and thus we may theoretically
// exceed Smi::kMaxValue. But, 1) this is very unlikely since it'd take
// quite some time to exhaust the budget that many times; and 2) even an
// overflow doesn't hurt us at all.
__ Ldr(ticks, FieldMemOperand(feedback_vector,
FeedbackVector::kProfilerTicksOffset));
__ Add(ticks, ticks, Immediate(1));
__ Str(ticks, FieldMemOperand(feedback_vector,
FeedbackVector::kProfilerTicksOffset));
}
// JSFunction::SetInterruptBudget.
{