AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Drop unused name parameter of SetPropertyToField().

Browse Source 
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/233673007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20667 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
bmeurer@chromium.org 2014-04-11 07:15:17 +00:00
parent 166ec11e43
commit 1a9fa3a673
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/objects.cc
View File

@ -4020,7 +4020,6 @@ MaybeHandle<Object> JSObject::SetPropertyUsingTransition(
static void SetPropertyToField(LookupResult* lookup, static void SetPropertyToField(LookupResult* lookup,
Handle<Name> name,
Handle<Object> value) { Handle<Object> value) {
Representation representation = lookup->representation(); Representation representation = lookup->representation();
if (!lookup->CanHoldValue(value) || if (!lookup->CanHoldValue(value) ||
@ -4083,7 +4082,7 @@ static void SetPropertyToFieldWithAttributes(LookupResult* lookup,
PropertyAttributes attributes) { PropertyAttributes attributes) {
if (lookup->GetAttributes() == attributes) { if (lookup->GetAttributes() == attributes) {
if (value->IsUninitialized()) return; if (value->IsUninitialized()) return;
SetPropertyToField(lookup, name, value); SetPropertyToField(lookup, value);
} else { } else {
ConvertAndSetLocalProperty(lookup, name, value, attributes); ConvertAndSetLocalProperty(lookup, name, value, attributes);
} }
@ -4178,12 +4177,12 @@ MaybeHandle<Object> JSObject::SetPropertyForResult(
SetNormalizedProperty(handle(lookup->holder()), lookup, value); SetNormalizedProperty(handle(lookup->holder()), lookup, value);
break; break;
case FIELD: case FIELD:
SetPropertyToField(lookup, name, value); SetPropertyToField(lookup, value);
break; break;
case CONSTANT: case CONSTANT:
// Only replace the constant if necessary. // Only replace the constant if necessary.
if (*value == lookup->GetConstant()) return value; if (*value == lookup->GetConstant()) return value;
SetPropertyToField(lookup, name, value); SetPropertyToField(lookup, value);
break; break;
case CALLBACKS: { case CALLBACKS: {
Handle<Object> callback_object(lookup->GetCallbackObject(), isolate); Handle<Object> callback_object(lookup->GetCallbackObject(), isolate);