AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Make string test resilient against GC stress.

Browse Source 
R=dcarney@chromium.org
TEST=cctest/test-strings/StringCharacterStreamRandom

Review URL: https://codereview.chromium.org/11565031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
mstarzinger@chromium.org 2012-12-14 12:45:28 +00:00
parent e24b98312b
commit 1aed997ad6
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/cctest/test-strings.cc
View File

@ -671,10 +671,10 @@ void TestStringCharacterStream(BuildString build, int test_cases) {
HandleScope outer_scope(isolate);
ZoneScope zone(Isolate::Current()->runtime_zone(), DELETE_ON_EXIT);
ConsStringGenerationData data(true);
bool last_test_did_gc = false;
for (int i = 0; i < test_cases; i++) {
printf("%d\n", i);
HandleScope inner_scope(isolate);
AlwaysAllocateScope always_allocate;
// Build flat version of cons string.
Handle<String> flat_string = build(i, &data);
ConsStringStats flat_string_stats;
@ -685,22 +685,6 @@ void TestStringCharacterStream(BuildString build, int test_cases) {
Handle<String> cons_string = build(i, &data);
ConsStringStats cons_string_stats;
AccumulateStats(cons_string, &cons_string_stats);
// Check if gc changed our data structure.
bool broken_by_gc =
cons_string_stats.leaves_ != data.stats_.leaves_ ||
cons_string_stats.leaves_ != flat_string_stats.leaves_;
// If gc altered the data structure, do a full collection and retry test.
if (broken_by_gc) {
// Bail if test runs twice.
if (last_test_did_gc) CHECK(false);
printf("forcing gc\n");
isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags, "retry test");
// Retry test.
last_test_did_gc = true;
i--;
continue;
}
last_test_did_gc = false;
AssertNoAllocation no_alloc;
PrintStats(data);
// Full verify of cons string.