AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Make run-tests.py warn when it's not testing anything

Browse Source 
I've often been confused by an "all passed" run of the test script
when it turned out that either all the tests I cared about were skipped
or, more likely, I mistyped the name(s) of the tests I wanted to run.
This patch aims to fix that (and gives a useful diagnostic for the
"all matched tests were skipped" case).

R=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1283513003

Cr-Commit-Position: refs/heads/master@{#30095}
This commit is contained in:
adamk 2015-08-10 11:16:23 -07:00 committed by Commit bot
parent 34c5640956
commit 1b1de2d221
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/run-tests.py
View File

@ -532,8 +532,6 @@ def Main():
def Execute(arch, mode, args, options, suites, workspace): def Execute(arch, mode, args, options, suites, workspace):
print(">>> Running tests for %s.%s" % (arch, mode))
shell_dir = options.shell_dir shell_dir = options.shell_dir
if not shell_dir: if not shell_dir:
if options.buildbot: if options.buildbot:
@ -651,6 +649,14 @@ def Execute(arch, mode, args, options, suites, workspace):
if options.cat: if options.cat:
return 0 # We're done here. return 0 # We're done here.
if num_tests == 0:
print("No tests selected for running!")
if len(all_tests) > 0:
verbose.PrintReport(all_tests)
return 0
print(">>> Running tests for %s.%s" % (arch, mode))
if options.report: if options.report:
verbose.PrintReport(all_tests) verbose.PrintReport(all_tests)