From 1bc48138a6cb90501473d094edf66a599a2619a6 Mon Sep 17 00:00:00 2001 From: adamk Date: Thu, 5 Jan 2017 10:11:37 -0800 Subject: [PATCH] [class fields] Remove a bit of dead code leftover from cleanup R=littledan@chromium.org BUG=v8:5367 Review-Url: https://codereview.chromium.org/2611063002 Cr-Commit-Position: refs/heads/master@{#42097} --- src/objects-inl.h | 4 ---- src/objects.h | 12 ++---------- src/parsing/parse-info.cc | 9 --------- src/parsing/parse-info.h | 2 -- src/parsing/parser.h | 1 - 5 files changed, 2 insertions(+), 26 deletions(-) diff --git a/src/objects-inl.h b/src/objects-inl.h index 20d43d43d5..244e66d4d1 100644 --- a/src/objects-inl.h +++ b/src/objects-inl.h @@ -6223,10 +6223,6 @@ BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, must_use_ignition_turbo, BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush) BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_asm_wasm_broken, kIsAsmWasmBroken) -BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, requires_class_field_init, - kRequiresClassFieldInit) -BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_class_field_initializer, - kIsClassFieldInitializer) bool Script::HasValidSource() { Object* src = this->source(); diff --git a/src/objects.h b/src/objects.h index 3905d37813..4b7e0031c7 100644 --- a/src/objects.h +++ b/src/objects.h @@ -7451,12 +7451,6 @@ class SharedFunctionInfo: public HeapObject { // Indicates that code for this function cannot be flushed. DECL_BOOLEAN_ACCESSORS(dont_flush) - // Indicates that this is a constructor for a base class with instance fields. - DECL_BOOLEAN_ACCESSORS(requires_class_field_init) - // Indicates that this is a synthesized function to set up class instance - // fields. - DECL_BOOLEAN_ACCESSORS(is_class_field_initializer) - // Indicates that this function is an asm function. DECL_BOOLEAN_ACCESSORS(asm_function) @@ -7738,13 +7732,12 @@ class SharedFunctionInfo: public HeapObject { kAllowLazyCompilation, kMarkedForTierUp, kOptimizationDisabled, - kIsClassFieldInitializer, + kHasDuplicateParameters, kNative, kStrictModeFunction, kUsesArguments, kNeedsHomeObject, // byte 1 - kHasDuplicateParameters, kForceInline, kIsAsmFunction, kIsAnonymousExpression, @@ -7752,14 +7745,13 @@ class SharedFunctionInfo: public HeapObject { kIsFunction, kMustUseIgnitionTurbo, kDontFlush, + kIsDeclaration, // byte 2 kFunctionKind, // rest of byte 2 and first two bits of byte 3 are used by FunctionKind // byte 3 kDeserialized = kFunctionKind + 10, - kIsDeclaration, kIsAsmWasmBroken, - kRequiresClassFieldInit, kCompilerHintsCount, // Pseudo entry }; // kFunctionKind has to be byte-aligned diff --git a/src/parsing/parse-info.cc b/src/parsing/parse-info.cc index 9dedf9830e..b703d3e924 100644 --- a/src/parsing/parse-info.cc +++ b/src/parsing/parse-info.cc @@ -94,15 +94,6 @@ bool ParseInfo::is_declaration() const { return (compiler_hints_ & (1 << SharedFunctionInfo::kIsDeclaration)) != 0; } -bool ParseInfo::requires_class_field_init() const { - return (compiler_hints_ & - (1 << SharedFunctionInfo::kRequiresClassFieldInit)) != 0; -} -bool ParseInfo::is_class_field_initializer() const { - return (compiler_hints_ & - (1 << SharedFunctionInfo::kIsClassFieldInitializer)) != 0; -} - FunctionKind ParseInfo::function_kind() const { return SharedFunctionInfo::FunctionKindBits::decode(compiler_hints_); } diff --git a/src/parsing/parse-info.h b/src/parsing/parse-info.h index 4b66dd0c4d..87052a5a7e 100644 --- a/src/parsing/parse-info.h +++ b/src/parsing/parse-info.h @@ -162,8 +162,6 @@ class V8_EXPORT_PRIVATE ParseInfo { // Getters for individual compiler hints. bool is_declaration() const; - bool requires_class_field_init() const; - bool is_class_field_initializer() const; FunctionKind function_kind() const; //-------------------------------------------------------------------------- diff --git a/src/parsing/parser.h b/src/parsing/parser.h index 6c77856303..45ef959ed4 100644 --- a/src/parsing/parser.h +++ b/src/parsing/parser.h @@ -593,7 +593,6 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase) { int pos); Expression* SpreadCallNew(Expression* function, ZoneList* args, int pos); - Expression* CallClassFieldInitializer(Scope* scope, Expression* this_expr); Expression* RewriteSuperCall(Expression* call_expression); void SetLanguageMode(Scope* scope, LanguageMode mode);