From 1c972cff7673e5af732a0f06cd0e481f31e3a381 Mon Sep 17 00:00:00 2001 From: Victor Gomes Date: Fri, 21 Oct 2022 12:18:34 +0000 Subject: [PATCH] Revert "[bazel] Add hide symbols from release / fast builds" This reverts commit 6e4dea75e8e66d47bbfb0b0832400e32e6e57620. Reason for revert: This is blocking HEAD import in Copybara. Let's test this there first, then backport the change. Original change's description: > [bazel] Add hide symbols from release / fast builds > > > Our gn build files hide non-exported symbols by default, which results > in smaller binaries and can improve build times. > > This was not ported to the bazel build and causes binary size > regressions in google 3. > > Change-Id: I285914b83e75bd3bf406e6401f52ddb53230219a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3925698 > Commit-Queue: Camillo Bruni > Reviewed-by: Patrick Thier > Cr-Commit-Position: refs/heads/main@{#83514} Change-Id: I18561cfdd8a637c100be849c4d6a668c6f3b6080 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3971120 Reviewed-by: Patrick Thier Commit-Queue: Patrick Thier Auto-Submit: Victor Gomes Commit-Queue: Victor Gomes Cr-Commit-Position: refs/heads/main@{#83850} --- bazel/defs.bzl | 8 -------- 1 file changed, 8 deletions(-) diff --git a/bazel/defs.bzl b/bazel/defs.bzl index 3205e9439f..77e86ef6f2 100644 --- a/bazel/defs.bzl +++ b/bazel/defs.bzl @@ -151,14 +151,6 @@ def _default_args(): "-fno-integrated-as", ], "//conditions:default": [], - }) + select({ - "@v8//bazel/config:is_debug":[ - "-fvisibility=default", - ], - "//conditions:default": [ - "-fvisibility=hidden", - "-fvisibility-inlines-hidden", - ], }), includes = ["include"], linkopts = select({