AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Fix flaky unittests/RuntimeCallStatsTest.GarbageCollection

Browse Source 
The test fails because of the race condition between concurrent GC
threads and the destructor of the test.

Bug: v8:11413
Change-Id: I5a138a61c16ddf2398e7c54defe6cc4008ca3330
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2839552
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74065}
This commit is contained in:
Ulan Degenbaev 2021-04-20 13:11:09 +02:00 committed by Commit Bot
parent 5540fbfce5
commit 1cac58d58e
3 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/inspector/inspector.status
View File

@ -24,9 +24,6 @@
# The initial CL only fixed the crash. The test still causes an endless
# loop instead of properly reporting a RangeError for a stack overflow.
'regress/regress-crbug-1080638': [SKIP],
# https://crbug.com/v8/11338
'runtime-call-stats/enable-disable': [PASS, ['verify_csa', SKIP]],
}], # ALWAYS
##############################################################################

4
test/unittests/logging/runtime-call-stats-unittest.cc
View File

@ -623,6 +623,10 @@ TEST_F(RuntimeCallStatsTest, ApiGetter) {
TEST_F(RuntimeCallStatsTest, GarbageCollection) {
FLAG_expose_gc = true;
// Disable concurrent GC threads because otherwise they may continue
// running after this test completes and race with is_runtime_stats_enabled()
// updates.
FLAG_single_threaded_gc = true;
v8::Isolate* isolate = v8_isolate();
RunJS(
"let root = [];"

6
test/unittests/unittests.status
View File

@ -3,12 +3,6 @@
# found in the LICENSE file.
[
##############################################################################
[ALWAYS, {
# https://crbug.com/v8/11413
'RuntimeCallStatsTest.GarbageCollection': [PASS, ['verify_csa', SKIP]],
}], # ALWAYS
##############################################################################
['system == macos and asan', {
# BUG(820416).