AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

cppgc: Fix ODR violation in unittests target

Browse Source 
V8 already depends on cppgc_base which means that unittests does not
need to depend on cppgc_for_testing any longer.

Move the cppgc_for_testing dependency to the stand-alone
cppgc_unittests binary

Bug: v8:10674
Change-Id: I07bfe30901eb1683d2e0ee0189f73b5244884f27
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310249
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68970}
This commit is contained in:
Michael Lippautz 2020-07-21 16:55:04 +02:00 committed by Commit Bot
parent 92135e06a7
commit 1cb7c70707
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/unittests/BUILD.gn
View File

@ -35,6 +35,7 @@ v8_executable("cppgc_unittests") {
deps = [
":cppgc_unittests_sources",
"../..:cppgc_for_testing",
"//testing/gmock",
"//testing/gtest",
]
@ -85,7 +86,6 @@ v8_source_set("cppgc_unittests_sources") {
]
deps = [
"../..:cppgc_for_testing",
"//testing/gmock",
"//testing/gtest",
]