AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[sparkplug] Remove OSR tracing for baseline

Browse Source 
With batch compilation, tracing messages for OSR were wrong and
misleading.
Since we can trace when and where we enter baseline code with other
flags (--trace-unoptimized) we can remove tracing for baseline OSR.

Bug: v8:11420
Change-Id: I72483c9262b7009652664739b692fd32bd936e20
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988403
Auto-Submit: Patrick Thier <pthier@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75405}
This commit is contained in:
Patrick Thier 2021-06-25 11:41:43 +00:00 committed by V8 LUCI CQ
parent 3386d84133
commit 1cf6b70499
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/codegen/compiler.cc
View File

@ -1971,15 +1971,6 @@ bool Compiler::CompileSharedWithBaseline(Isolate* isolate,
// Arm back edges for OSR
shared->GetBytecodeArray(isolate).set_osr_loop_nesting_level(
AbstractCode::kMaxLoopNestingMarker);
if (FLAG_trace_osr) {
JavaScriptFrameIterator it(isolate);
DCHECK(it.frame()->is_unoptimized());
UnoptimizedFrame* frame = UnoptimizedFrame::cast(it.frame());
CodeTracer::Scope scope(isolate->GetCodeTracer());
PrintF(scope.file(),
"[OSR - Entry at OSR bytecode offset %d into baseline code]\n",
frame->GetBytecodeOffset());
}
}
}
double time_taken_ms = time_taken.InMillisecondsF();