AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Update comment about TODO in verify_source_deps.py

Browse Source 
Forgot to include that in the previous CL

TBR=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2354513002
Cr-Commit-Position: refs/heads/master@{#39500}
This commit is contained in:
jochen 2016-09-19 04:40:17 -07:00 committed by Commit bot
parent d7ef0b8c97
commit 1d75f17c63
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/verify_source_deps.py
View File

@ -8,9 +8,8 @@ Script to print potentially missing source dependencies based on the actual
.h and .cc files in the source tree and which files are included in the gyp
and gn files. The latter inclusion is overapproximated.
TODO(machenbach): Gyp files in src will point to source files in src without a
src/ prefix. For simplicity, all paths relative to src are stripped. But this
tool won't be accurate for other sources in other directories (e.g. cctest).
TODO(machenbach): If two source files with the same name exist, but only one
is referenced from a gyp/gn file, we won't necessarily detect it.
"""
import itertools