AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[arm64] Fix a string test in StringCompareStub.

Browse Source 
This fixes a regression in Octane's pdf.js after r30818. The bug itself
has been present for a long time, but StringCompareStub wasn't actually
used until r30818 so it went unnoticed.

Review URL: https://codereview.chromium.org/1399983002

Cr-Commit-Position: refs/heads/master@{#31227}
This commit is contained in:
jacob.bramley 2015-10-13 01:40:33 -07:00 committed by Commit bot
parent 8e4ceb613d
commit 1d9d7821ff
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/arm64/macro-assembler-arm64.cc
View File

@ -2424,9 +2424,10 @@ void MacroAssembler::JumpIfEitherInstanceTypeIsNotSequentialOneByte(
Label* failure) {
DCHECK(!AreAliased(scratch1, second));
DCHECK(!AreAliased(scratch1, scratch2));
static const int kFlatOneByteStringMask =
const int kFlatOneByteStringMask =
kIsNotStringMask | kStringEncodingMask | kStringRepresentationMask;
static const int kFlatOneByteStringTag = ONE_BYTE_STRING_TYPE;
const int kFlatOneByteStringTag =
kStringTag | kOneByteStringTag | kSeqStringTag;
And(scratch1, first, kFlatOneByteStringMask);
And(scratch2, second, kFlatOneByteStringMask);
Cmp(scratch1, kFlatOneByteStringTag);