AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[regexp] Increase number of backtracks before fallback

Browse Source 
This commit increases the number of backtracks before we fall back to
the experimental engine.  The previous limit was reached just before
irregexp finished in sunspider/string-tagcloud and
web-tooling-benchmark/coffeescript.  This meant that we aborted
execution and started over with a slower (but asymptotically faster)
engine just before we would've finished, causing a performance
regression.

Bug: chromium:1138975,v8:10765
Change-Id: I10a4b149300f88680084604310730ee91758bfa0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2479010
Commit-Queue: Martin Bidlingmaier <mbid@google.com>
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70673}
This commit is contained in:
Martin Bidlingmaier 2020-10-16 15:28:16 +02:00 committed by Commit Bot
parent c7cb9beca1
commit 1e0b92aea9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flags/flag-definitions.h
View File

@ -1503,7 +1503,7 @@ DEFINE_BOOL(trace_experimental_regexp_engine, false,
DEFINE_BOOL(enable_experimental_regexp_engine_on_excessive_backtracks, true, DEFINE_BOOL(enable_experimental_regexp_engine_on_excessive_backtracks, true,
"fall back to a breadth-first regexp engine on excessive " "fall back to a breadth-first regexp engine on excessive "
"backtracking") "backtracking")
DEFINE_UINT(regexp_backtracks_before_fallback, 10000, DEFINE_UINT(regexp_backtracks_before_fallback, 50000,
"number of backtracks during regexp execution before fall back " "number of backtracks during regexp execution before fall back "
"to experimental engine if " "to experimental engine if "
"enable_experimental_regexp_engine_on_excessive_backtracks is set") "enable_experimental_regexp_engine_on_excessive_backtracks is set")