AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Update reclient version, allow mac to checkout reclient, add mac builder

Browse Source 
Mac builder added per https://chromium-review.googlesource.com/c/v8/v8/+/3755921/comments/dc378d70_002b4107

Bump the re-client version to match the same one chromium is currently using: https://source.chromium.org/chromium/chromium/src/+/main:DEPS;l=265;drc=11428e8ebaf6a78020d442da479b5b0daa0dffb5

The older version of re-client 0.40.0.40ff5a5 will not work when attempting to use it in a recipe targeting mac

The version bump has been tested successfully with V8 Official Linux64 (reclient) dd361303d1/+/build.proto and V8 Linux64 - builder (reclient) 758cd57ad9/+/build.proto

Bug: b:238283947
Change-Id: I88e306f930c030173813b591e63a363da2d47cf1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3752430
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Richard Wang <richardwa@google.com>
Cr-Commit-Position: refs/heads/main@{#81656}
This commit is contained in:
Richard Wang 2022-07-12 11:07:49 +09:00 committed by V8 LUCI CQ
parent c3e0ad47b1
commit 1e1cdca1f4
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
DEPS
View File

@ -40,7 +40,7 @@ vars = {
'fuchsia_sdk_cipd_prefix': 'fuchsia/sdk/gn/',
# reclient CIPD package version
'reclient_version': 're_client_version:0.40.0.40ff5a5',
'reclient_version': 're_client_version:0.69.0.458df98-gomaip',
# GN CIPD package version.
'gn_version': 'git_revision:9ef321772ecc161937db69acb346397e0ccc484d',
@ -140,7 +140,7 @@ deps = {
}
],
'dep_type': 'cipd',
'condition': '(host_os == "linux" or host_os == "win") and checkout_reclient',
'condition': '(host_os == "linux" or host_os == "mac" or host_os == "win") and checkout_reclient',
},
'test/benchmarks/data':
Var('chromium_url') + '/v8/deps/third_party/benchmarks.git' + '@' + '05d7188267b4560491ff9155c5ee13e207ecd65f',

1
infra/mb/mb_config.pyl
View File

@ -90,6 +90,7 @@
# Mac.
'V8 Mac64 - builder': 'release_x64',
'V8 Mac64 - debug builder': 'debug_x64',
'V8 Mac64 - builder (reclient)': 'release_x64_reclient',
'V8 Official Mac ARM64': 'release_arm64',
'V8 Official Mac ARM64 Debug': 'debug_arm64',
'V8 Mac64 ASAN - builder': 'release_x64_asan_no_lsan',