AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[interpreter] Use interpreter on all function literals.

Browse Source 
This fixes a path in the compilation pipeline that side-stepped the
interpreter when a function literal was eagerly compiled. This caused
the interpreter to miss some test coverage.

R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/1528853002

Cr-Commit-Position: refs/heads/master@{#32867}
This commit is contained in:
mstarzinger 2015-12-15 06:12:34 -08:00 committed by Commit bot
parent a337d159d3
commit 1e385a832a
3 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler.cc
View File

@ -1577,8 +1577,7 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfo(
// called.
info.EnsureFeedbackVector();
scope_info = Handle<ScopeInfo>(ScopeInfo::Empty(isolate));
} else if (Renumber(info.parse_info()) &&
FullCodeGenerator::MakeCode(&info)) {
} else if (Renumber(info.parse_info()) && GenerateBaselineCode(&info)) {
// Code generation will ensure that the feedback vector is present and
// appropriately sized.
DCHECK(!info.code().is_null());

20
test/mjsunit/mjsunit.status
View File

@ -1042,6 +1042,26 @@
'with-prototype': [SKIP],
'with-readonly': [SKIP],
'regress/typed-array-lifetime': [SKIP],
'regress/regress-crbug-522895': [SKIP],
'regress/regress-crbug-455644': [SKIP],
'regress/regress-crbug-109362': [SKIP],
'regress/regress-crbug-429159': [SKIP],
'regress/regress-crbug-517592': [SKIP],
'regress/regress-crbug-405517': [SKIP],
'regress/regress-799761': [SKIP],
'regress/regress-503565': [SKIP],
'regress/regress-3138': [SKIP],
'regress/regress-220': [SKIP],
'regress/regress-1170187': [SKIP],
'regress/regress-1030466': [SKIP],
'regress/regress-1853': [SKIP],
'with-value': [SKIP],
'with-function-expression': [SKIP],
'switch': [SKIP],
'receiver-in-with-calls': [SKIP],
'local-load-from-eval': [SKIP],
'deserialize-optimize-inner': [SKIP],
'delete-in-with': [SKIP],
}], # ignition == True
['ignition == True and (arch == arm or arch == arm64)', {

8
test/test262/test262.status
View File

@ -531,6 +531,7 @@
'built-ins/Array/prototype/reduce/*': [SKIP],
'built-ins/Array/prototype/reduceRight/*': [SKIP],
'built-ins/decodeURI*': [SKIP],
'built-ins/GeneratorFunction/*': [SKIP],
'built-ins/GeneratorPrototype/*': [SKIP],
'built-ins/Map/*': [SKIP],
'built-ins/MapIteratorPrototype/*': [SKIP],
@ -627,6 +628,13 @@
'language/statements/function/S13.2.2_A19_T7': [SKIP],
'language/statements/function/S13.2.2_A19_T8': [SKIP],
'language/statements/while/S12.6.2_A4_T5': [SKIP],
'language/block-scope/leave/nested-block-let-declaration-only-shadows-outer-parameter-value-1': [SKIP],
'language/block-scope/leave/nested-block-let-declaration-only-shadows-outer-parameter-value-2': [SKIP],
'language/block-scope/leave/verify-context-in-labelled-block': [SKIP],
'language/expressions/object/method-definition/name-prop-name-yield-expr': [SKIP],
'language/statements/function/S13.2.2_A18_T1': [SKIP],
'language/statements/function/S13.2.2_A17_T2': [SKIP],
'language/statements/function/S13.2.2_A17_T3': [SKIP],
}], # ignition == True
['ignition == True and (arch == arm or arch == arm64)', {