AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

X64 Crankshaft: Fix error in pushed register indices for safepoints. Fixes issue 1153.

Browse Source 
BUG=1153
TEST=mjsunit/date-parse

Review URL: http://codereview.chromium.org/6518007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
whesse@chromium.org 2011-02-14 16:02:02 +00:00
parent 7233a930b5
commit 1e4800b918
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/x64/macro-assembler-x64.cc
View File

@ -1442,6 +1442,7 @@ void MacroAssembler::Pushad() {
// r13 is kRootRegister.
push(r14);
// r15 is kSmiConstantRegister
STATIC_ASSERT(11 == kRegistersPushedByPushad);
}
@ -1461,7 +1462,6 @@ void MacroAssembler::Popad() {
void MacroAssembler::Dropad() {
const int kRegistersPushedByPushad = 11;
addq(rsp, Immediate(kRegistersPushedByPushad * kPointerSize));
}

5
src/x64/macro-assembler-x64.h
View File

@ -171,7 +171,8 @@ class MacroAssembler: public Assembler {
void PushSafepointRegisters() { Pushad(); }
void PopSafepointRegisters() { Popad(); }
static int SafepointRegisterStackIndex(int reg_code) {
return kSafepointPushRegisterIndices[reg_code];
return kRegistersPushedByPushad - 1 -
kSafepointPushRegisterIndices[reg_code];
}
@ -966,6 +967,8 @@ class MacroAssembler: public Assembler {
// Order general registers are pushed by Pushad.
// rax, rcx, rdx, rbx, rsi, rdi, r8, r9, r11, r12, r14.
static int kSafepointPushRegisterIndices[Register::kNumRegisters];
static const int kRegistersPushedByPushad = 11;
bool generating_stub_;
bool allow_stub_calls_;

3
test/mjsunit/mjsunit.status
View File

@ -125,9 +125,6 @@ compiler/simple-osr: SKIP
# BUG (1094)
regress/regress-deopt-gc: SKIP
# BUG (1153)
date-parse: SKIP
##############################################################################
[ $arch == mips ]