From 1f36c542ae569cc55786c08ecd4a9aba690b07dc Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Tue, 1 Dec 2020 10:25:39 +0100 Subject: [PATCH] [foozzie] Make harness more robust to unknown flags When one comparison run crashes, we cap the outputs to compare to the shorter one. If one of those, however, contains ignored lines, the comparison get's skewed. This makes the main source of ignored lines more robust (the line printed for unknown flags), by not printing it in the first place in the context of differential fuzzing. Bug: chromium:1153871 Change-Id: If2e534959779be14a686be5e43630cbf66e215a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567692 Auto-Submit: Michael Achenbach Reviewed-by: Clemens Backes Commit-Queue: Clemens Backes Cr-Commit-Position: refs/heads/master@{#71522} --- src/d8/d8.cc | 4 +++- tools/clusterfuzz/v8_suppressions.py | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/d8/d8.cc b/src/d8/d8.cc index b281051565..532dcc32c9 100644 --- a/src/d8/d8.cc +++ b/src/d8/d8.cc @@ -3600,7 +3600,9 @@ bool Shell::SetOptions(int argc, char* argv[]) { } else if (strcmp(str, "--module") == 0) { // Pass on to SourceGroup, which understands this option. } else if (strncmp(str, "--", 2) == 0) { - printf("Warning: unknown flag %s.\nTry --help for options\n", str); + if (!i::FLAG_correctness_fuzzer_suppressions) { + printf("Warning: unknown flag %s.\nTry --help for options\n", str); + } } else if (strcmp(str, "-e") == 0 && i + 1 < argc) { set_script_executed(); } else if (strncmp(str, "-", 1) != 0) { diff --git a/tools/clusterfuzz/v8_suppressions.py b/tools/clusterfuzz/v8_suppressions.py index 71c69fb6b2..e8b3bd0d80 100644 --- a/tools/clusterfuzz/v8_suppressions.py +++ b/tools/clusterfuzz/v8_suppressions.py @@ -70,7 +70,6 @@ ALLOWED_LINE_DIFFS = [ # Lines matching any of the following regular expressions will be ignored. # Use uncompiled regular expressions - they'll be compiled later. IGNORE_LINES = [ - r'^Warning: unknown flag .*$', r'^Warning: .+ is deprecated.*$', r'^Try --help for options$',