AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Enable --build-v8-with-gn for Node.js bots.

Browse Source 
Bug: v8:6105
Change-Id: Idfc10bdab9c69d2d5f751197e3df068406bd521a
Reviewed-on: https://chromium-review.googlesource.com/868131
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50638}
This commit is contained in:
Yang Guo 2018-01-17 07:59:23 +01:00 committed by Commit Bot
parent c090806fe8
commit 1f3cdb701a
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/node/fetch_deps.py
View File

@ -61,12 +61,6 @@ def EnsureGit(v8_path):
return True return True
def FetchDeps(v8_path): def FetchDeps(v8_path):
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
# Verify path. # Verify path.
v8_path = os.path.abspath(v8_path) v8_path = os.path.abspath(v8_path)
assert os.path.isdir(v8_path) assert os.path.isdir(v8_path)
@ -94,6 +88,8 @@ def FetchDeps(v8_path):
os.path.join(v8_path, os.pardir, ".gclient_entries")) os.path.join(v8_path, os.pardir, ".gclient_entries"))
if os.path.isfile(gclient_entries): if os.path.isfile(gclient_entries):
os.remove(gclient_entries) os.remove(gclient_entries)
# Enable building with GN for configure script.
return True
if __name__ == "__main__": if __name__ == "__main__":