AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[runtime] Fix handling of interceptors, pt.2

Browse Source 
Bug: chromium:1216437
Change-Id: Ib8439aefc778beefed4dc40290473311cc23d5f9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944937
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74994}
This commit is contained in:
Igor Sheludko 2021-06-07 20:20:44 +02:00 committed by V8 LUCI CQ
parent 13a5125212
commit 1f5113816c
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/objects/objects.cc
View File

@ -2655,6 +2655,8 @@ Maybe<bool> Object::SetProperty(LookupIterator* it, Handle<Object> value,
if (found) return result; if (found) return result;
} }
// TODO(ishell): refactor this: both SetProperty and and SetSuperProperty have
// this piece of code.
// If the receiver is the JSGlobalObject, the store was contextual. In case // If the receiver is the JSGlobalObject, the store was contextual. In case
// the property did not exist yet on the global object itself, we have to // the property did not exist yet on the global object itself, we have to
// throw a reference error in strict mode. In sloppy mode, we continue. // throw a reference error in strict mode. In sloppy mode, we continue.
@ -2762,6 +2764,25 @@ Maybe<bool> Object::SetSuperProperty(LookupIterator* it, Handle<Object> value,
} }
} }
// TODO(ishell): refactor this: both SetProperty and and SetSuperProperty have
// this piece of code.
// If the receiver is the JSGlobalObject, the store was contextual. In case
// the property did not exist yet on the global object itself, we have to
// throw a reference error in strict mode. In sloppy mode, we continue.
if (receiver->IsJSGlobalObject() &&
(GetShouldThrow(isolate, should_throw) == ShouldThrow::kThrowOnError)) {
if (own_lookup.state() == LookupIterator::TRANSITION) {
// The property cell that we have created is garbage because we are going
// to throw now instead of putting it into the global dictionary. However,
// the cell might already have been stored into the feedback vector, so
// we must invalidate it nevertheless.
own_lookup.transition_cell()->ClearAndInvalidate(ReadOnlyRoots(isolate));
}
isolate->Throw(*isolate->factory()->NewReferenceError(
MessageTemplate::kNotDefined, own_lookup.GetName()));
return Nothing<bool>();
}
return AddDataProperty(&own_lookup, value, NONE, should_throw, store_origin); return AddDataProperty(&own_lookup, value, NONE, should_throw, store_origin);
} }