AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove CodeStubAssembler from final binary

Browse Source 
With the last remaining TF code stubs gone, c-s-a.{h,cc} is no longer
needed in the final binary.

Bug: v8:7777
Change-Id: I8573199401678758698df56e0cb680f125f06bdc
Reviewed-on: https://chromium-review.googlesource.com/c/1346329
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57721}
This commit is contained in:
Jakob Gruber 2018-11-21 13:46:31 +01:00 committed by Commit Bot
parent 32df006b94
commit 1f6d5a4362
4 changed files with 5 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
BUILD.gn
View File

@ -1404,6 +1404,8 @@ v8_source_set("v8_initializers") {
"src/builtins/growable-fixed-array-gen.cc",
"src/builtins/growable-fixed-array-gen.h",
"src/builtins/setup-builtins-internal.cc",
"src/code-stub-assembler.cc",
"src/code-stub-assembler.h",
"src/heap/setup-heap-internal.cc",
"src/ic/accessor-assembler.cc",
"src/ic/accessor-assembler.h",
@ -1425,9 +1427,10 @@ v8_source_set("v8_initializers") {
"src/builtins/builtins-async-iterator-gen.cc",
"src/builtins/builtins-async-generator-gen.cc",
# This source file takes an unusually large amount of time to
# compile. Build it separately to avoid bottlenecks.
# These source files take an unusually large amount of time to
# compile. Build them separately to avoid bottlenecks.
"src/builtins/builtins-regexp-gen.cc",
"src/code-stub-assembler.cc",
]
}
@ -1676,8 +1679,6 @@ v8_source_set("v8_base") {
"src/code-factory.h",
"src/code-reference.cc",
"src/code-reference.h",
"src/code-stub-assembler.cc",
"src/code-stub-assembler.h",
"src/code-stubs-utils.h",
"src/code-stubs.cc",
"src/code-stubs.h",
@ -2686,7 +2687,6 @@ v8_source_set("v8_base") {
# These source files take an unusually large amount of time to
# compile. Build them separately to avoid bottlenecks.
"src/api.cc",
"src/code-stub-assembler.cc",
"src/elements.cc",
"src/heap/heap.cc",
"src/objects.cc",

1
src/builtins/builtins-array.cc
View File

@ -5,7 +5,6 @@
#include "src/builtins/builtins-utils-inl.h"
#include "src/builtins/builtins.h"
#include "src/code-factory.h"
#include "src/code-stub-assembler.h"
#include "src/contexts.h"
#include "src/counters.h"
#include "src/debug/debug.h"

13
src/code-stubs.cc
View File

@ -11,7 +11,6 @@
#include "src/ast/ast.h"
#include "src/bootstrapper.h"
#include "src/code-factory.h"
#include "src/code-stub-assembler.h"
#include "src/code-stubs-utils.h"
#include "src/code-tracer.h"
#include "src/counters.h"
@ -254,18 +253,6 @@ MaybeHandle<Code> CodeStub::GetCode(Isolate* isolate, uint32_t key) {
return scope.CloseAndEscape(code);
}
Handle<Code> TurboFanCodeStub::GenerateCode() {
const char* name = CodeStub::MajorName(MajorKey());
Zone zone(isolate()->allocator(), ZONE_NAME);
CallInterfaceDescriptor descriptor(GetCallInterfaceDescriptor());
compiler::CodeAssemblerState state(
isolate(), &zone, descriptor, Code::STUB, name,
PoisoningMitigationLevel::kDontPoison, GetKey());
GenerateAssembly(&state);
return compiler::CodeAssembler::GenerateCode(
&state, AssemblerOptions::Default(isolate()));
}
int JSEntryStub::GenerateHandlerTable(MacroAssembler* masm) {
int handler_table_offset = HandlerTable::EmitReturnTableStart(masm, 1);
HandlerTable::EmitReturnEntry(masm, 0, handler_offset_);

19
src/code-stubs.h
View File

@ -360,25 +360,6 @@ class CodeStubDescriptor {
bool has_miss_handler_;
};
class TurboFanCodeStub : public CodeStub {
public:
// Retrieve the code for the stub. Generate the code if needed.
Handle<Code> GenerateCode() override;
int GetStackParameterCount() const override {
return GetCallInterfaceDescriptor().GetStackParameterCount();
}
protected:
explicit TurboFanCodeStub(Isolate* isolate) : CodeStub(isolate) {}
virtual void GenerateAssembly(compiler::CodeAssemblerState* state) const = 0;
private:
DEFINE_CODE_STUB_BASE(TurboFanCodeStub, CodeStub);
};
} // namespace internal
} // namespace v8