AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[arm][arm64] Fix --trace-osr

Browse Source 
Read only a single byte of FLAG_trace_osr in assembly builtin code to
make asan happy in the simulator.

Bug: chromium:1324042
Change-Id: I002cea0b4917af3780d6bdedfb0ec55008e146c7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644793
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Auto-Submit: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80532}
This commit is contained in:
Camillo Bruni 2022-05-13 18:40:03 +02:00 committed by V8 LUCI CQ
parent e0d0fa2dec
commit 1fcfc6a6d9
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/builtins/arm/builtins-arm.cc
View File

@ -1867,7 +1867,7 @@ void OnStackReplacement(MacroAssembler* masm, OsrSourceTier source,
{
Label next;
__ Move(r1, ExternalReference::address_of_FLAG_trace_osr());
__ ldr(r1, MemOperand(r1));
__ ldrsb(r1, MemOperand(r1));
__ tst(r1, Operand(0xFF)); // Mask to the LSB.
__ b(eq, &next);

2
src/builtins/arm64/builtins-arm64.cc
View File

@ -2101,7 +2101,7 @@ void OnStackReplacement(MacroAssembler* masm, OsrSourceTier source,
{
Label next;
__ Mov(x1, ExternalReference::address_of_FLAG_trace_osr());
__ Ldr(x1, MemOperand(x1));
__ Ldrsb(x1, MemOperand(x1));
__ Tst(x1, 0xFF); // Mask to the LSB.
__ B(eq, &next);