AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[bazel] Remove zlib dependency

Browse Source 
That entails that V8 built with bazel does not support
snapshot compression.

NOTE: Snapshot compression has always been supported, but it has never
been enabled. We do not even have a flag for it.

Change-Id: I4b67db618be2c62e6a6f34e71eb0dac2ec26fa36
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834031
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82537}
This commit is contained in:
Victor Gomes 2022-08-16 16:29:00 +02:00 committed by V8 LUCI CQ
parent 456202730c
commit 208bda4824
3 changed files with 0 additions and 91 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
BUILD.bazel
View File

@ -324,7 +324,6 @@ v8_config(
}, },
defines = [ defines = [
"GOOGLE3", "GOOGLE3",
"CHROMIUM_ZLIB_NO_CHROMECONF",
"ENABLE_DEBUGGER_SUPPORT", "ENABLE_DEBUGGER_SUPPORT",
"V8_ADVANCED_BIGINT_ALGORITHMS", "V8_ADVANCED_BIGINT_ALGORITHMS",
"V8_CONCURRENT_MARKING", "V8_CONCURRENT_MARKING",
@ -2091,8 +2090,6 @@ filegroup(
"src/snapshot/shared-heap-deserializer.cc", "src/snapshot/shared-heap-deserializer.cc",
"src/snapshot/shared-heap-serializer.h", "src/snapshot/shared-heap-serializer.h",
"src/snapshot/shared-heap-serializer.cc", "src/snapshot/shared-heap-serializer.cc",
"src/snapshot/snapshot-compression.cc",
"src/snapshot/snapshot-compression.h",
"src/snapshot/snapshot-data.cc", "src/snapshot/snapshot-data.cc",
"src/snapshot/snapshot-data.h", "src/snapshot/snapshot-data.h",
"src/snapshot/snapshot-source-sink.cc", "src/snapshot/snapshot-source-sink.cc",
@ -3575,8 +3572,6 @@ v8_library(
deps = [ deps = [
":v8_libbase", ":v8_libbase",
"//external:base_trace_event_common", "//external:base_trace_event_common",
"//external:zlib",
"//external:zlib_compression_utils",
], ],
) )

16
WORKSPACE
View File

@ -34,22 +34,6 @@ pip_install(
requirements = "//:bazel/requirements.txt", requirements = "//:bazel/requirements.txt",
) )
new_local_repository(
name = "com_googlesource_chromium_zlib",
build_file = "bazel/BUILD.zlib",
path = "third_party/zlib",
)
bind(
name = "zlib",
actual = "@com_googlesource_chromium_zlib//:zlib",
)
bind(
name = "zlib_compression_utils",
actual = "@com_googlesource_chromium_zlib//:zlib_compression_utils",
)
new_local_repository( new_local_repository(
name = "com_googlesource_chromium_icu", name = "com_googlesource_chromium_icu",
build_file = "bazel/BUILD.icu", build_file = "bazel/BUILD.icu",

70
bazel/BUILD.zlib
View File

@ -1,70 +0,0 @@
# Copyright 2021 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
cc_library(
name = "zlib",
srcs = [
"adler32.c",
"chromeconf.h",
"compress.c",
"contrib/optimizations/insert_string.h",
"cpu_features.c",
"cpu_features.h",
"crc32.c",
"crc32.h",
"deflate.c",
"deflate.h",
"gzclose.c",
"gzguts.h",
"gzlib.c",
"gzread.c",
"gzwrite.c",
"infback.c",
"inffast.c",
"inffast.h",
"inffixed.h",
"inflate.c",
"inflate.h",
"inftrees.c",
"inftrees.h",
"slide_hash_simd.h",
"trees.c",
"trees.h",
"uncompr.c",
"zconf.h",
"zlib.h",
"zutil.c",
"zutil.h",
],
hdrs = [
"zlib.h",
],
defines = [
"CHROMIUM_ZLIB_NO_CHROMECONF",
"CPU_NO_SIMD",
] + select({
"@platforms//os:windows": [],
"//conditions:default": [
"HAVE_HIDDEN",
],
}),
include_prefix = "third_party/zlib",
visibility = ["//visibility:public"],
)
cc_library(
name = "zlib_compression_utils",
srcs = [
"google/compression_utils_portable.cc",
],
hdrs = [
"google/compression_utils_portable.h",
],
include_prefix = "third_party/zlib",
visibility = ["//visibility:public"],
copts = ["-Wnodeprecated-non-prototype"],
deps = [
"//external:zlib",
],
)