AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix off-by-one error in AstTyper, part 2.

Browse Source 
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/112933002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18308 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yangguo@chromium.org 2013-12-12 15:19:57 +00:00
parent 48ff79a300
commit 213b05b5b9
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/typing.h
View File

@ -83,8 +83,11 @@ class AstTyper: public AstVisitor {
void ExitEffects() { store_ = store_.Pop(); }
int variable_index(Variable* var) {
// Stack locals have the range [0 .. l]
// Parameters have the range [-1 .. p]
// We map this to [-p-2 .. -1, 0 .. l]
return var->IsStackLocal() ? var->index() :
var->IsParameter() ? -var->index() - 1 : kNoVar;
var->IsParameter() ? -var->index() - 2 : kNoVar;
}
void VisitDeclarations(ZoneList<Declaration*>* declarations);

14
test/mjsunit/regress/regress-param-local-type.js
View File

@ -42,3 +42,17 @@ f(1);
%OptimizeFunctionOnNextCall(f);
f(1);
assertOptimized(f);
function g() { // 0th parameter (receiver) is tagged.
var s = ''; // First local has string type.
var n = 0;
var i = 1;
n = i + this;
}
g.call(1);
g.call(1);
%OptimizeFunctionOnNextCall(g);
g.call(1);
assertOptimized(g);