From 215e6bcb0033dc1f50948d862c8d3dbce11cf96c Mon Sep 17 00:00:00 2001 From: mstarzinger Date: Mon, 9 Feb 2015 05:13:15 -0800 Subject: [PATCH] Remove dependency on v8.h from TurboFan. R=bmeurer@chromium.org TEST=presubmit Review URL: https://codereview.chromium.org/905293002 Cr-Commit-Position: refs/heads/master@{#26525} --- src/compiler/DEPS | 3 +++ src/compiler/all-nodes.h | 1 - src/compiler/arm/linkage-arm.cc | 2 -- src/compiler/arm64/linkage-arm64.cc | 2 -- src/compiler/ast-graph-builder.h | 2 -- src/compiler/ast-loop-assignment-analyzer.h | 1 - src/compiler/basic-block-instrumentor.h | 2 -- src/compiler/control-builders.h | 2 -- src/compiler/control-equivalence.h | 2 -- src/compiler/diamond.h | 2 -- src/compiler/frame.h | 2 -- src/compiler/graph-builder.h | 2 -- src/compiler/ia32/linkage-ia32.cc | 2 -- src/compiler/js-context-specialization.h | 1 - src/compiler/js-inlining.h | 1 - src/compiler/mips/linkage-mips.cc | 2 -- src/compiler/mips64/linkage-mips64.cc | 2 -- src/compiler/pipeline.h | 2 -- src/compiler/ppc/linkage-ppc.cc | 2 -- src/compiler/raw-machine-assembler.h | 2 -- src/compiler/register-allocator-verifier.h | 1 - src/compiler/register-configuration.cc | 1 + src/compiler/register-configuration.h | 2 +- src/compiler/scheduler.h | 2 -- src/compiler/typer.h | 2 -- src/compiler/verifier.h | 2 +- src/compiler/x64/linkage-x64.cc | 2 -- src/compiler/zone-pool.h | 2 +- 28 files changed, 7 insertions(+), 44 deletions(-) create mode 100644 src/compiler/DEPS diff --git a/src/compiler/DEPS b/src/compiler/DEPS new file mode 100644 index 0000000000..60e2f6d742 --- /dev/null +++ b/src/compiler/DEPS @@ -0,0 +1,3 @@ +include_rules = [ + "-src/v8.h", +] diff --git a/src/compiler/all-nodes.h b/src/compiler/all-nodes.h index 2406d27c0b..e6a83ef623 100644 --- a/src/compiler/all-nodes.h +++ b/src/compiler/all-nodes.h @@ -7,7 +7,6 @@ #include "src/compiler/graph.h" #include "src/compiler/node.h" -#include "src/v8.h" #include "src/zone-containers.h" namespace v8 { diff --git a/src/compiler/arm/linkage-arm.cc b/src/compiler/arm/linkage-arm.cc index 0d9ca12d99..57590d3e5b 100644 --- a/src/compiler/arm/linkage-arm.cc +++ b/src/compiler/arm/linkage-arm.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/assembler.h" #include "src/code-stubs.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/arm64/linkage-arm64.cc b/src/compiler/arm64/linkage-arm64.cc index 142d8dd2e3..57945fd77f 100644 --- a/src/compiler/arm64/linkage-arm64.cc +++ b/src/compiler/arm64/linkage-arm64.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/assembler.h" #include "src/code-stubs.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/ast-graph-builder.h b/src/compiler/ast-graph-builder.h index 658e7368d4..030868cd33 100644 --- a/src/compiler/ast-graph-builder.h +++ b/src/compiler/ast-graph-builder.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_AST_GRAPH_BUILDER_H_ #define V8_COMPILER_AST_GRAPH_BUILDER_H_ -#include "src/v8.h" - #include "src/ast.h" #include "src/compiler/js-graph.h" diff --git a/src/compiler/ast-loop-assignment-analyzer.h b/src/compiler/ast-loop-assignment-analyzer.h index 00a7f2d79d..38eed5b635 100644 --- a/src/compiler/ast-loop-assignment-analyzer.h +++ b/src/compiler/ast-loop-assignment-analyzer.h @@ -7,7 +7,6 @@ #include "src/ast.h" #include "src/bit-vector.h" -#include "src/v8.h" #include "src/zone-containers.h" namespace v8 { diff --git a/src/compiler/basic-block-instrumentor.h b/src/compiler/basic-block-instrumentor.h index 7edac0dbe8..353b0c2ba7 100644 --- a/src/compiler/basic-block-instrumentor.h +++ b/src/compiler/basic-block-instrumentor.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_BASIC_BLOCK_INSTRUMENTOR_H_ #define V8_COMPILER_BASIC_BLOCK_INSTRUMENTOR_H_ -#include "src/v8.h" - #include "src/basic-block-profiler.h" namespace v8 { diff --git a/src/compiler/control-builders.h b/src/compiler/control-builders.h index 656b94a9e4..c22ee04a98 100644 --- a/src/compiler/control-builders.h +++ b/src/compiler/control-builders.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_CONTROL_BUILDERS_H_ #define V8_COMPILER_CONTROL_BUILDERS_H_ -#include "src/v8.h" - #include "src/compiler/ast-graph-builder.h" #include "src/compiler/node.h" diff --git a/src/compiler/control-equivalence.h b/src/compiler/control-equivalence.h index cca087fe83..5c97f01e87 100644 --- a/src/compiler/control-equivalence.h +++ b/src/compiler/control-equivalence.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_CONTROL_EQUIVALENCE_H_ #define V8_COMPILER_CONTROL_EQUIVALENCE_H_ -#include "src/v8.h" - #include "src/compiler/graph.h" #include "src/compiler/node.h" #include "src/compiler/node-properties.h" diff --git a/src/compiler/diamond.h b/src/compiler/diamond.h index fad24cdb72..cf83638bba 100644 --- a/src/compiler/diamond.h +++ b/src/compiler/diamond.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_DIAMOND_H_ #define V8_COMPILER_DIAMOND_H_ -#include "src/v8.h" - #include "src/compiler/common-operator.h" #include "src/compiler/graph.h" #include "src/compiler/node.h" diff --git a/src/compiler/frame.h b/src/compiler/frame.h index ce1ecd061c..a5dd11657b 100644 --- a/src/compiler/frame.h +++ b/src/compiler/frame.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_FRAME_H_ #define V8_COMPILER_FRAME_H_ -#include "src/v8.h" - #include "src/bit-vector.h" namespace v8 { diff --git a/src/compiler/graph-builder.h b/src/compiler/graph-builder.h index 02d6ff08fd..f2fb7f6c09 100644 --- a/src/compiler/graph-builder.h +++ b/src/compiler/graph-builder.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_GRAPH_BUILDER_H_ #define V8_COMPILER_GRAPH_BUILDER_H_ -#include "src/v8.h" - #include "src/allocation.h" #include "src/compiler/common-operator.h" #include "src/compiler/graph.h" diff --git a/src/compiler/ia32/linkage-ia32.cc b/src/compiler/ia32/linkage-ia32.cc index aaf954497b..19dbc43f20 100644 --- a/src/compiler/ia32/linkage-ia32.cc +++ b/src/compiler/ia32/linkage-ia32.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/assembler.h" #include "src/code-stubs.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/js-context-specialization.h b/src/compiler/js-context-specialization.h index 298d3a39f8..b707755fc7 100644 --- a/src/compiler/js-context-specialization.h +++ b/src/compiler/js-context-specialization.h @@ -8,7 +8,6 @@ #include "src/compiler/graph-reducer.h" #include "src/compiler/js-graph.h" #include "src/contexts.h" -#include "src/v8.h" namespace v8 { namespace internal { diff --git a/src/compiler/js-inlining.h b/src/compiler/js-inlining.h index acaa4a724a..5e6b39a027 100644 --- a/src/compiler/js-inlining.h +++ b/src/compiler/js-inlining.h @@ -6,7 +6,6 @@ #define V8_COMPILER_JS_INLINING_H_ #include "src/compiler/js-graph.h" -#include "src/v8.h" namespace v8 { namespace internal { diff --git a/src/compiler/mips/linkage-mips.cc b/src/compiler/mips/linkage-mips.cc index 1534b0bdd5..cbb59d3a10 100644 --- a/src/compiler/mips/linkage-mips.cc +++ b/src/compiler/mips/linkage-mips.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/assembler.h" #include "src/code-stubs.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/mips64/linkage-mips64.cc b/src/compiler/mips64/linkage-mips64.cc index b10ee2f7ee..273054e206 100644 --- a/src/compiler/mips64/linkage-mips64.cc +++ b/src/compiler/mips64/linkage-mips64.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/assembler.h" #include "src/code-stubs.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/pipeline.h b/src/compiler/pipeline.h index b2ea1935ed..2813770e30 100644 --- a/src/compiler/pipeline.h +++ b/src/compiler/pipeline.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_PIPELINE_H_ #define V8_COMPILER_PIPELINE_H_ -#include "src/v8.h" - // Clients of this interface shouldn't depend on lots of compiler internals. // Do not include anything from src/compiler here! #include "src/compiler.h" diff --git a/src/compiler/ppc/linkage-ppc.cc b/src/compiler/ppc/linkage-ppc.cc index 1008981ff7..38117222a9 100644 --- a/src/compiler/ppc/linkage-ppc.cc +++ b/src/compiler/ppc/linkage-ppc.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/assembler.h" #include "src/code-stubs.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/raw-machine-assembler.h b/src/compiler/raw-machine-assembler.h index f6437a8da5..646ace2e00 100644 --- a/src/compiler/raw-machine-assembler.h +++ b/src/compiler/raw-machine-assembler.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_ #define V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_ -#include "src/v8.h" - #include "src/compiler/common-operator.h" #include "src/compiler/graph-builder.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/register-allocator-verifier.h b/src/compiler/register-allocator-verifier.h index 70552fbfdd..86fda1670d 100644 --- a/src/compiler/register-allocator-verifier.h +++ b/src/compiler/register-allocator-verifier.h @@ -5,7 +5,6 @@ #ifndef V8_REGISTER_ALLOCATOR_VERIFIER_H_ #define V8_REGISTER_ALLOCATOR_VERIFIER_H_ -#include "src/v8.h" #include "src/zone-containers.h" namespace v8 { diff --git a/src/compiler/register-configuration.cc b/src/compiler/register-configuration.cc index e7d8bbd607..30946fc373 100644 --- a/src/compiler/register-configuration.cc +++ b/src/compiler/register-configuration.cc @@ -3,6 +3,7 @@ // found in the LICENSE file. #include "src/compiler/register-configuration.h" +#include "src/globals.h" #include "src/macro-assembler.h" namespace v8 { diff --git a/src/compiler/register-configuration.h b/src/compiler/register-configuration.h index 8178ba2f0d..f0d58735ba 100644 --- a/src/compiler/register-configuration.h +++ b/src/compiler/register-configuration.h @@ -5,7 +5,7 @@ #ifndef V8_COMPILER_REGISTER_CONFIGURATION_H_ #define V8_COMPILER_REGISTER_CONFIGURATION_H_ -#include "src/v8.h" +#include "src/base/macros.h" namespace v8 { namespace internal { diff --git a/src/compiler/scheduler.h b/src/compiler/scheduler.h index 882c761f2d..269c271ae5 100644 --- a/src/compiler/scheduler.h +++ b/src/compiler/scheduler.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_SCHEDULER_H_ #define V8_COMPILER_SCHEDULER_H_ -#include "src/v8.h" - #include "src/base/flags.h" #include "src/compiler/node.h" #include "src/compiler/opcodes.h" diff --git a/src/compiler/typer.h b/src/compiler/typer.h index 87246ff794..a288d060a6 100644 --- a/src/compiler/typer.h +++ b/src/compiler/typer.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_TYPER_H_ #define V8_COMPILER_TYPER_H_ -#include "src/v8.h" - #include "src/compiler/graph.h" #include "src/compiler/opcodes.h" #include "src/types.h" diff --git a/src/compiler/verifier.h b/src/compiler/verifier.h index 67b7ba6e71..8c5962fcad 100644 --- a/src/compiler/verifier.h +++ b/src/compiler/verifier.h @@ -5,7 +5,7 @@ #ifndef V8_COMPILER_VERIFIER_H_ #define V8_COMPILER_VERIFIER_H_ -#include "src/v8.h" +#include "src/base/macros.h" namespace v8 { namespace internal { diff --git a/src/compiler/x64/linkage-x64.cc b/src/compiler/x64/linkage-x64.cc index 45dc931c76..802edf3554 100644 --- a/src/compiler/x64/linkage-x64.cc +++ b/src/compiler/x64/linkage-x64.cc @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/assembler.h" #include "src/code-stubs.h" #include "src/compiler/linkage.h" diff --git a/src/compiler/zone-pool.h b/src/compiler/zone-pool.h index d2fbbbd92f..09d6183e00 100644 --- a/src/compiler/zone-pool.h +++ b/src/compiler/zone-pool.h @@ -9,7 +9,7 @@ #include #include -#include "src/v8.h" +#include "src/zone.h" namespace v8 { namespace internal {