Let test configuration disable variant flags. Used for preparser tests.

Fixes problem with nosse[234] tests (or anything else that would pass an
unexpected extra parameter on the preparser test command line).

Review URL: http://codereview.chromium.org/6965008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7814 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
lrn@chromium.org 2011-05-09 09:02:27 +00:00
parent 89c64653bf
commit 217006f111
2 changed files with 17 additions and 10 deletions

View File

@ -110,6 +110,9 @@ class PreparserTestConfiguration(test.TestConfiguration):
if exists(status_file):
test.ReadConfigurationInto(status_file, sections, defs)
def VariantFlags(self):
return [[]];
def GetConfiguration(context, root):
return PreparserTestConfiguration(context, root)

View File

@ -392,7 +392,7 @@ class TestCase(object):
result = self.RunCommand(self.GetCommand())
except:
self.terminate = True
raise BreakNowException("Used pressed CTRL+C or IO went wrong")
raise BreakNowException("User pressed CTRL+C or IO went wrong")
finally:
self.AfterRun(result)
return result
@ -566,6 +566,13 @@ def CarCdr(path):
return (path[0], path[1:])
# Use this to run several variants of the tests, e.g.:
# VARIANT_FLAGS = [[], ['--always_compact', '--noflush_code']]
VARIANT_FLAGS = [[],
['--stress-opt', '--always-opt'],
['--nocrankshaft']]
class TestConfiguration(object):
def __init__(self, context, root):
@ -583,6 +590,11 @@ class TestConfiguration(object):
def GetTestStatus(self, sections, defs):
pass
def VariantFlags(self):
return VARIANT_FLAGS
class TestSuite(object):
@ -593,13 +605,6 @@ class TestSuite(object):
return self.name
# Use this to run several variants of the tests, e.g.:
# VARIANT_FLAGS = [[], ['--always_compact', '--noflush_code']]
VARIANT_FLAGS = [[],
['--stress-opt', '--always-opt'],
['--nocrankshaft']]
class TestRepository(TestSuite):
def __init__(self, path):
@ -627,12 +632,11 @@ class TestRepository(TestSuite):
return self.GetConfiguration(context).GetBuildRequirements()
def AddTestsToList(self, result, current_path, path, context, mode):
for v in VARIANT_FLAGS:
for v in self.GetConfiguration(context).VariantFlags():
tests = self.GetConfiguration(context).ListTests(current_path, path, mode, v)
for t in tests: t.variant_flags = v
result += tests
def GetTestStatus(self, context, sections, defs):
self.GetConfiguration(context).GetTestStatus(sections, defs)