AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cppgc] check on a valid shared_ptr.

Browse Source 
This CL fixes calling CHECK_NULL on a moved shared_ptr.

Bug: v8:13589
Change-Id: I52ab261df7e995f4a9fcfd7a2a3c2c0012a4c94f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135701
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85093}
This commit is contained in:
yangwenming 2023-01-04 22:16:07 +08:00 committed by V8 LUCI CQ
parent bc4bac3877
commit 22ef44b655
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/heap/cppgc/heap-base.cc
View File

@ -101,7 +101,7 @@ class PlatformWithPageAllocator final : public cppgc::Platform {
page_allocator_(GetGlobalPageAllocator()) {
// This platform wrapper should only be used if the platform doesn't provide
// a `PageAllocator`.
CHECK_NULL(delegate->GetPageAllocator());
CHECK_NULL(delegate_->GetPageAllocator());
}
~PlatformWithPageAllocator() override = default;