AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Add testing of --write-protect-code-memory feature.

Browse Source 
This adds test coverage for write-protected code pages by adding the
feature to the existing "stress_incremental_marking" variant. Since this
is considered a temporary state, the variant has not been renamed.

R=machenbach@chromium.org
BUG=v8:6792

Change-Id: I62fa5aa15bf5309b12fbc269fcf81069845755f9
Reviewed-on: https://chromium-review.googlesource.com/753388
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49267}
This commit is contained in:
Michael Starzinger 2017-11-08 16:30:01 +01:00 committed by Commit Bot
parent 22d4e6e8e3
commit 2328e4d196
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/testrunner/local/variants.py
View File

@ -6,7 +6,9 @@
ALL_VARIANT_FLAGS = {
"default": [[]],
"stress": [["--stress-opt", "--always-opt"]],
"stress_incremental_marking": [["--stress-incremental-marking"]],
# TODO(6792): Write protected code has been temporary added to the below
# variant until the feature has been enabled (or staged) by default.
"stress_incremental_marking": [["--stress-incremental-marking", "--write-protect-code-memory"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall
# would not force optimization too. It turns into a Nop. Please see
# https://chromium-review.googlesource.com/c/452620/ for more discussion.
@ -19,7 +21,9 @@ ALL_VARIANT_FLAGS = {
FAST_VARIANT_FLAGS = {
"default": [[]],
"stress": [["--stress-opt"]],
"stress_incremental_marking": [["--stress-incremental-marking"]],
# TODO(6792): Write protected code has been temporary added to the below
# variant until the feature has been enabled (or staged) by default.
"stress_incremental_marking": [["--stress-incremental-marking", "--write-protect-code-memory"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall
# would not force optimization too. It turns into a Nop. Please see
# https://chromium-review.googlesource.com/c/452620/ for more discussion.