AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

RegExp: Remove unnecessary function from ARM specific code and convert condition to assertion.

Browse Source 
Review URL: http://codereview.chromium.org/178034


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
lrn@chromium.org 2009-09-02 07:34:51 +00:00
parent 4339205dd2
commit 23e84069c8
3 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/arm/regexp-macro-assembler-arm.cc
View File

@ -132,15 +132,6 @@ int RegExpMacroAssemblerARM::stack_limit_slack() {
} }
bool RegExpMacroAssemblerARM::CanReadUnaligned() {
#if V8_TARGET_CAN_READ_UNALIGNED
return true;
#else
return false;
#endif
}
void RegExpMacroAssemblerARM::AdvanceCurrentPosition(int by) { void RegExpMacroAssemblerARM::AdvanceCurrentPosition(int by) {
if (by != 0) { if (by != 0) {
Label inside_string; Label inside_string;

1
src/arm/regexp-macro-assembler-arm.h
View File

@ -45,7 +45,6 @@ class RegExpMacroAssemblerARM: public NativeRegExpMacroAssembler {
RegExpMacroAssemblerARM(Mode mode, int registers_to_save); RegExpMacroAssemblerARM(Mode mode, int registers_to_save);
virtual ~RegExpMacroAssemblerARM(); virtual ~RegExpMacroAssemblerARM();
virtual int stack_limit_slack(); virtual int stack_limit_slack();
virtual bool CanReadUnaligned();
virtual void AdvanceCurrentPosition(int by); virtual void AdvanceCurrentPosition(int by);
virtual void AdvanceRegister(int reg, int by); virtual void AdvanceRegister(int reg, int by);
virtual void Backtrack(); virtual void Backtrack();

4
src/jsregexp.cc
View File

@ -1723,8 +1723,8 @@ bool RegExpNode::EmitQuickCheck(RegExpCompiler* compiler,
GetQuickCheckDetails(details, compiler, 0, trace->at_start() == Trace::FALSE); GetQuickCheckDetails(details, compiler, 0, trace->at_start() == Trace::FALSE);
if (details->cannot_match()) return false; if (details->cannot_match()) return false;
if (!details->Rationalize(compiler->ascii())) return false; if (!details->Rationalize(compiler->ascii())) return false;
if (details->characters() > 1 && ASSERT(details->characters() == 1 ||
!compiler->macro_assembler()->CanReadUnaligned()) return false; compiler->macro_assembler()->CanReadUnaligned());
uint32_t mask = details->mask(); uint32_t mask = details->mask();
uint32_t value = details->value(); uint32_t value = details->value();