AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[runtime] Ensure {JSGeneratorObject} is created for bytecode.

Browse Source 
This removes some outdated code that allocates a {JSGeneratorObject} for
baseline code. We no longer support such a representation of generators
and can rely on bytecode being available for all generators.

R=neis@chromium.org

Review-Url: https://codereview.chromium.org/2515253003
Cr-Commit-Position: refs/heads/master@{#41137}
This commit is contained in:
mstarzinger 2016-11-21 05:02:18 -08:00 committed by Commit bot
parent 8ca50a8862
commit 2405ab11b5
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/runtime/runtime-generator.cc
View File

@ -19,17 +19,11 @@ RUNTIME_FUNCTION(Runtime_CreateJSGeneratorObject) {
CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 1);
CHECK(IsResumableFunction(function->shared()->kind()));
Handle<FixedArray> operand_stack;
if (function->shared()->HasBytecodeArray()) {
// New-style generators.
DCHECK(!function->shared()->HasBaselineCode());
int size = function->shared()->bytecode_array()->register_count();
operand_stack = isolate->factory()->NewFixedArray(size);
} else {
// Old-style generators.
DCHECK(function->shared()->HasBaselineCode());
operand_stack = isolate->factory()->empty_fixed_array();
}
// Underlying function needs to have bytecode available.
DCHECK(function->shared()->HasBytecodeArray());
DCHECK(!function->shared()->HasBaselineCode());
int size = function->shared()->bytecode_array()->register_count();
Handle<FixedArray> operand_stack = isolate->factory()->NewFixedArray(size);
Handle<JSGeneratorObject> generator =
isolate->factory()->NewJSGeneratorObject(function);