AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove unused parameter from AllocateUninitializedJSArray* variants

Browse Source 
Change-Id: I9eec3c31cdf1441d3187e5d882ca4b88e7b698e7
Reviewed-on: https://chromium-review.googlesource.com/691726
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Daniel Clifford <danno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48225}
This commit is contained in:
Daniel Clifford 2017-09-29 11:31:47 +02:00 committed by Commit Bot
parent 69aa6e5736
commit 24714efa59
5 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/builtins/builtins-constructor-gen.cc
View File

@ -471,7 +471,7 @@ Node* ConstructorBuiltinsAssembler::EmitCreateShallowArrayLiteral(
BIND(&allocate_without_elements);
{
Node* array = AllocateUninitializedJSArrayWithoutElements(
PACKED_ELEMENTS, boilerplate_map, length.value(), allocation_site);
boilerplate_map, length.value(), allocation_site);
StoreObjectField(array, JSObject::kElementsOffset, elements.value());
result.Bind(array);
Goto(&return_result);

2
src/builtins/builtins-object-gen.cc
View File

@ -187,7 +187,7 @@ TF_BUILTIN(ObjectKeys, ObjectBuiltinsAssembler) {
Node* native_context = LoadNativeContext(context);
Node* array_map = LoadJSArrayElementsMap(PACKED_ELEMENTS, native_context);
Node* array = AllocateUninitializedJSArrayWithoutElements(
PACKED_ELEMENTS, array_map, var_length.value(), nullptr);
array_map, var_length.value(), nullptr);
StoreObjectFieldNoWriteBarrier(array, JSArray::kElementsOffset,
var_elements.value());
Return(array);

2
src/builtins/builtins-regexp-gen.cc
View File

@ -1906,7 +1906,7 @@ class GrowableFixedArray {
Node* const result_length = a->SmiTag(length());
Node* const result = a->AllocateUninitializedJSArrayWithoutElements(
kind, array_map, result_length, nullptr);
array_map, result_length, nullptr);
// Note: We do not currently shrink the fixed array.

17
src/code-stub-assembler.cc
View File

@ -2431,7 +2431,7 @@ void CodeStubAssembler::StoreFieldsNoWriteBarrier(Node* start_address,
}
Node* CodeStubAssembler::AllocateUninitializedJSArrayWithoutElements(
ElementsKind kind, Node* array_map, Node* length, Node* allocation_site) {
Node* array_map, Node* length, Node* allocation_site) {
Comment("begin allocation of JSArray without elements");
CSA_SLOW_ASSERT(this, TaggedIsPositiveSmi(length));
CSA_SLOW_ASSERT(this, IsMap(array_map));
@ -2441,8 +2441,8 @@ Node* CodeStubAssembler::AllocateUninitializedJSArrayWithoutElements(
}
Node* size = IntPtrConstant(base_size);
Node* array = AllocateUninitializedJSArray(kind, array_map, length,
allocation_site, size);
Node* array =
AllocateUninitializedJSArray(array_map, length, allocation_site, size);
return array;
}
@ -2465,8 +2465,8 @@ CodeStubAssembler::AllocateUninitializedJSArrayWithElements(
base_size += FixedArray::kHeaderSize;
Node* size = ElementOffsetFromIndex(capacity, kind, capacity_mode, base_size);
Node* array = AllocateUninitializedJSArray(kind, array_map, length,
allocation_site, size);
Node* array =
AllocateUninitializedJSArray(array_map, length, allocation_site, size);
Node* elements = InnerAllocate(array, elements_offset);
StoreObjectFieldNoWriteBarrier(array, JSObject::kElementsOffset, elements);
@ -2484,8 +2484,7 @@ CodeStubAssembler::AllocateUninitializedJSArrayWithElements(
return {array, elements};
}
Node* CodeStubAssembler::AllocateUninitializedJSArray(ElementsKind kind,
Node* array_map,
Node* CodeStubAssembler::AllocateUninitializedJSArray(Node* array_map,
Node* length,
Node* allocation_site,
Node* size_in_bytes) {
@ -2523,7 +2522,7 @@ Node* CodeStubAssembler::AllocateJSArray(ElementsKind kind, Node* array_map,
if (IsIntPtrOrSmiConstantZero(capacity)) {
// Array is empty. Use the shared empty fixed array instead of allocating a
// new one.
array = AllocateUninitializedJSArrayWithoutElements(kind, array_map, length,
array = AllocateUninitializedJSArrayWithoutElements(array_map, length,
allocation_site);
StoreObjectFieldRoot(array, JSArray::kElementsOffset,
Heap::kEmptyFixedArrayRootIndex);
@ -2548,7 +2547,7 @@ Node* CodeStubAssembler::AllocateJSArray(ElementsKind kind, Node* array_map,
// Array is empty. Use the shared empty fixed array instead of allocating
// a new one.
var_array.Bind(AllocateUninitializedJSArrayWithoutElements(
kind, array_map, length, allocation_site));
array_map, length, allocation_site));
StoreObjectFieldRoot(var_array.value(), JSArray::kElementsOffset,
Heap::kEmptyFixedArrayRootIndex);
Goto(&out);

7
src/code-stub-assembler.h
View File

@ -706,8 +706,7 @@ class V8_EXPORT_PRIVATE CodeStubAssembler : public compiler::CodeAssembler {
int start_offset = JSObject::kHeaderSize);
// Allocate a JSArray without elements and initialize the header fields.
Node* AllocateUninitializedJSArrayWithoutElements(ElementsKind kind,
Node* array_map,
Node* AllocateUninitializedJSArrayWithoutElements(Node* array_map,
Node* length,
Node* allocation_site);
// Allocate and return a JSArray with initialized header fields and its
@ -1685,8 +1684,8 @@ class V8_EXPORT_PRIVATE CodeStubAssembler : public compiler::CodeAssembler {
Node* top_address, Node* limit_address);
// Allocate and return a JSArray of given total size in bytes with header
// fields initialized.
Node* AllocateUninitializedJSArray(ElementsKind kind, Node* array_map,
Node* length, Node* allocation_site,
Node* AllocateUninitializedJSArray(Node* array_map, Node* length,
Node* allocation_site,
Node* size_in_bytes);
Node* SmiShiftBitsConstant();