AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[runtime] JSObject::GetKeys never returns the EnumCache, so we don't need to copy in GetPropertyNames

Browse Source 
BUG=148757
LOG=n

Review URL: https://codereview.chromium.org/1766293002

Cr-Commit-Position: refs/heads/master@{#34536}
This commit is contained in:
verwaest 2016-03-07 04:41:14 -08:00 committed by Commit bot
parent cafe34ae4a
commit 25064ff988
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/api.cc
View File

@ -3783,11 +3783,10 @@ MaybeLocal<Array> v8::Object::GetPropertyNames(Local<Context> context) {
!i::JSReceiver::GetKeys(self, i::INCLUDE_PROTOS, i::ENUMERABLE_STRINGS)
.ToHandle(&value);
RETURN_ON_FAILED_EXECUTION(Array);
// Because we use caching to speed up enumeration it is important
// to never change the result of the basic enumeration function so
// we clone the result.
auto elms = isolate->factory()->CopyFixedArray(value);
auto result = isolate->factory()->NewJSArrayWithElements(elms);
DCHECK(self->map()->EnumLength() == i::kInvalidEnumCacheSentinel ||
self->map()->EnumLength() == 0 ||
self->map()->instance_descriptors()->GetEnumCache() != *value);
auto result = isolate->factory()->NewJSArrayWithElements(value);
RETURN_ESCAPED(Utils::ToLocal(result));
}