From 25a753383e256bf3b54812ef24e8f06a7e6460db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marja=20H=C3=B6ltt=C3=A4?= Date: Tue, 21 Nov 2017 16:34:53 +0100 Subject: [PATCH] [csa|interpreter] Remove unnecessary SMI tagging. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: Change-Id: Ic872ea78511f0ef3e8cea67b971162b71790a039 Reviewed-on: https://chromium-review.googlesource.com/781690 Reviewed-by: Ross McIlroy Reviewed-by: Igor Sheludko Commit-Queue: Marja Hölttä Cr-Commit-Position: refs/heads/master@{#49564} --- src/code-stub-assembler.cc | 2 +- src/interpreter/interpreter-assembler.cc | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc index 1f7762a946..a756be8c1e 100644 --- a/src/code-stub-assembler.cc +++ b/src/code-stub-assembler.cc @@ -7978,7 +7978,7 @@ Node* CodeStubAssembler::CreateWeakCellInFeedbackVector(Node* feedback_vector, // Store the WeakCell in the feedback vector. StoreFeedbackVectorSlot(feedback_vector, slot, cell, UPDATE_WRITE_BARRIER, 0, - CodeStubAssembler::SMI_PARAMETERS); + CodeStubAssembler::INTPTR_PARAMETERS); return cell; } diff --git a/src/interpreter/interpreter-assembler.cc b/src/interpreter/interpreter-assembler.cc index 9bf1573afd..61066155e2 100644 --- a/src/interpreter/interpreter-assembler.cc +++ b/src/interpreter/interpreter-assembler.cc @@ -668,7 +668,7 @@ void InterpreterAssembler::CollectCallableFeedback(Node* target, Node* context, } } BIND(&done_loop); - CreateWeakCellInFeedbackVector(feedback_vector, SmiTag(slot_id), target); + CreateWeakCellInFeedbackVector(feedback_vector, slot_id, target); ReportFeedbackUpdate(feedback_vector, slot_id, "Call:Initialize"); Goto(&done); } @@ -875,8 +875,7 @@ Node* InterpreterAssembler::Construct(Node* target, Node* context, BIND(&create_weak_cell); { - CreateWeakCellInFeedbackVector(feedback_vector, SmiTag(slot_id), - new_target); + CreateWeakCellInFeedbackVector(feedback_vector, slot_id, new_target); ReportFeedbackUpdate(feedback_vector, slot_id, "Construct:CreateWeakCell"); Goto(&construct); @@ -994,8 +993,7 @@ Node* InterpreterAssembler::ConstructWithSpread(Node* target, Node* context, GotoIfNot(WordEqual(LoadNativeContext(context), target_native_context), &mark_megamorphic); - CreateWeakCellInFeedbackVector(feedback_vector, SmiTag(slot_id), - new_target); + CreateWeakCellInFeedbackVector(feedback_vector, slot_id, new_target); ReportFeedbackUpdate(feedback_vector, slot_id, "ConstructWithSpread:Initialize"); Goto(&construct);