AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[tools][system-analyzer] Remove duplicate states in App

Browse Source 
This CL removes the duplicated code for handling global
state of the app. Increases readability of the app
class.

Bug: v8:10673, v8:10644

Change-Id: I08e0bfdc67e023264fce22a96bfd3ef94644e70c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2302894
Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
Commit-Queue: Zeynep Cankara <zcankara@google.com>
Cr-Commit-Position: refs/heads/master@{#68918}
This commit is contained in:
Zeynep Cankara 2020-07-16 20:38:43 +01:00 committed by Commit Bot
parent 7887ae6fc3
commit 25b4f9a68d
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tools/system-analyzer/index.mjs
View File

@ -16,7 +16,6 @@ class App {
this.timelinePanelId_ = timelinePanelId;
this.icPanelId_ = icPanelId;
this.icPanel_ = this.$(icPanelId);
this.state_ = Object.create(null);
document.addEventListener('keydown', e => this.handleKeyDown(e));
}
@ -56,17 +55,6 @@ class App {
}
}
// Update application state
updateDocumentState(){
document.state = this.state_.state;
try {
document.state.timeline = this.state_.timeline;
} catch (error) {
console.log(error);
console.log("cannot assign timeline to state!");
}
}
// Map event log processing
handleLoadTextMapProcessor(text) {
let mapProcessor = new MapProcessor();
@ -93,9 +81,12 @@ class App {
this.$('#container').style.display = 'block';
// instantiate the app logic
let fileData = e.detail;
this.state_.state = new State('#map-panel','#timeline-panel');
this.state_.timeline = this.handleLoadTextMapProcessor(fileData.chunk);
this.updateDocumentState();
document.state = new State(this.mapPanelId_, this.timelinePanelId_);
try {
document.state.timeline = this.handleLoadTextMapProcessor(fileData.chunk);
} catch (error) {
console.log(error);
}
this.loadICLogFile(fileData);
}