AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[mips32] Fix unused-but-set-variable check failures

Browse Source 
Some variables are only used in DCHECKs, which leading to the
`unused-but-set-variable` check fail in release mode.
So we need to explicitly mark them as used.

Change-Id: I18dc8ec97ea5fbbaa081a52629b9572b863d901e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3237558
Reviewed-by: Liu yu <liuyu@loongson.cn>
Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#77507}
This commit is contained in:
Zhao Jiazhong 2021-10-22 16:07:09 +08:00 committed by V8 LUCI CQ
parent cfe0a7a905
commit 25ca43f2ee
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/builtins/mips/builtins-mips.cc
View File

@ -501,6 +501,7 @@ void Generate_JSEntryVariant(MacroAssembler* masm, StackFrame::Type type,
Handle<Code> trampoline_code =
masm->isolate()->builtins()->code_handle(entry_trampoline);
DCHECK_EQ(kPushedStackSpace, pushed_stack_space);
USE(pushed_stack_space);
__ Call(trampoline_code, RelocInfo::CODE_TARGET);
// Unlink this frame from the handler chain.

1
src/execution/mips/simulator-mips.cc
View File

@ -3854,6 +3854,7 @@ void Simulator::DecodeTypeRegisterSPECIAL() {
int32_t res = _rs << sa;
res += _rt;
DCHECK_EQ(res, (rs() << (lsa_sa() + 1)) + rt());
USE(res);
SetResult(rd_reg(), (rs() << (lsa_sa() + 1)) + rt());
break;
}