AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Disable exception metadata

Browse Source 
Bug: chromium:1241860
Change-Id: Ieee7d5c67f1a42c0c9855148a7d497586d6c5555
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149456
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76753}
This commit is contained in:
Philip Pfaffe 2021-09-09 11:07:22 +02:00 committed by V8 LUCI CQ
parent 6391d7a58d
commit 25d5e50812
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/inspector/v8-inspector-impl.cc
View File

@ -348,14 +348,7 @@ v8::MaybeLocal<v8::Context> V8InspectorImpl::regexContext() {
}
v8::MaybeLocal<v8::Context> V8InspectorImpl::exceptionMetaDataContext() {
if (m_exceptionMetaDataContext.IsEmpty()) {
m_exceptionMetaDataContext.Reset(m_isolate, v8::Context::New(m_isolate));
if (m_exceptionMetaDataContext.IsEmpty()) {
DCHECK(m_isolate->IsExecutionTerminating());
return {};
}
}
return m_exceptionMetaDataContext.Get(m_isolate);
return {};
}
void V8InspectorImpl::discardInspectedContext(int contextGroupId,

3
test/inspector/inspector.status
View File

@ -20,6 +20,9 @@
# loop instead of properly reporting a RangeError for a stack overflow.
'regress/regress-crbug-1080638': [SKIP],
# https://crbug.com/1241860
'runtime/exception-thrown-metadata': [SKIP],
# Tests that need to run sequentially (e.g. due to memory consumption).
'runtime/console-messages-limits': [PASS, HEAVY],
'runtime/regression-732717': [PASS, HEAVY],