AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Support setter inlining in CountOperation.

Browse Source 
R=svenpanne@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23757018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16511 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
verwaest@chromium.org 2013-09-03 14:10:25 +00:00
parent 80dda72f4b
commit 26dc6c6e19
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/hydrogen.cc
View File

@ -5006,12 +5006,19 @@ void HOptimizedGraphBuilder::BuildStoreNamed(Expression* expr,
Handle<JSObject> holder;
if (LookupSetter(map, name, &setter, &holder)) {
AddCheckConstantFunction(holder, object, map);
// Don't try to inline if the result_value is different from the
// store_value. That case isn't handled yet by the inlining.
if (result_value == store_value &&
FLAG_inline_accessors &&
TryInlineSetter(setter, id, assignment_id, store_value)) {
return;
if (FLAG_inline_accessors) {
if (result_value != store_value) {
// The result_value and object are already pushed by CountOperation.
// Push(store_value) to complete the arguments to the setter.
Push(store_value);
bool check = TryInlineSetter(setter, id, assignment_id, store_value);
// Drop the result of the setter to return result_value that's on the
// stack already.
Drop(1);
if (check) return;
} else if (TryInlineSetter(setter, id, assignment_id, store_value)) {
return;
}
}
Drop(2);
Add<HPushArgument>(object);
@ -7572,6 +7579,9 @@ void HOptimizedGraphBuilder::VisitCountOperation(CountOperation* expr) {
after = BuildIncrement(returns_original_input, expr);
HValue* result = returns_original_input ? Pop() : after;
if (returns_original_input) {
environment()->SetExpressionStackAt(1, result);
}
return BuildStoreNamed(expr, expr->id(), expr->position(),
expr->AssignmentId(), prop, object, after, result);