AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove defensive programming for missing load/store eager bailout points.

Browse Source 
We now have all the required eager bailout points in place, so we can
remove the defensive programming in JSNativeContextSpecialization.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/1973773003
Cr-Commit-Position: refs/heads/master@{#36196}
This commit is contained in:
bmeurer 2016-05-12 00:21:14 -07:00 committed by Commit bot
parent 506999c306
commit 26ea37075a
1 changed files with 4 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/compiler/js-native-context-specialization.cc
View File

@ -435,12 +435,7 @@ Reduction JSNativeContextSpecialization::ReduceNamedAccess(
if (nexus.IsUninitialized()) { if (nexus.IsUninitialized()) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }
@ -452,12 +447,7 @@ Reduction JSNativeContextSpecialization::ReduceNamedAccess(
} else if (receiver_maps.length() == 0) { } else if (receiver_maps.length() == 0) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }
@ -917,12 +907,7 @@ Reduction JSNativeContextSpecialization::ReduceKeyedAccess(
if (nexus.IsUninitialized()) { if (nexus.IsUninitialized()) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }
@ -934,12 +919,7 @@ Reduction JSNativeContextSpecialization::ReduceKeyedAccess(
} else if (receiver_maps.length() == 0) { } else if (receiver_maps.length() == 0) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }