AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Compute dominator tree for tests

Browse Source 
The dominator tree is usually computed as part of scheduling (in
{Scheduler::ComputeSchedule}). For tests it was missing, leading to
DCHECK errors in the mid-tier register allocator, which uses the
dominator tree.

R=mslekova@chromium.org

Bug: v8:12330
Change-Id: I02bc8dee3aecb6a1613fa1d07d3aae85cd28de17
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245114
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77543}
This commit is contained in:
Clemens Backes 2021-10-26 11:19:02 +02:00 committed by V8 LUCI CQ
parent 2404758e8c
commit 26eeacb7ca
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/compiler/raw-machine-assembler.cc
View File

@ -95,6 +95,7 @@ Schedule* RawMachineAssembler::ExportForTest() {
}
schedule_->EnsureCFGWellFormedness();
Scheduler::ComputeSpecialRPO(zone(), schedule_);
Scheduler::GenerateDominatorTree(schedule_);
schedule_->PropagateDeferredMark();
if (FLAG_trace_turbo_scheduler) {
PrintF("--- EDGE SPLIT AND PROPAGATED DEFERRED SCHEDULE ------------\n");

13
test/cctest/compiler/test-run-machops.cc
View File

@ -18,6 +18,7 @@
#include "test/cctest/cctest.h"
#include "test/cctest/compiler/codegen-tester.h"
#include "test/cctest/compiler/value-helper.h"
#include "test/common/flag-utils.h"
namespace v8 {
namespace internal {
@ -7297,6 +7298,18 @@ TEST(Regression738952) {
CHECK_EQ(sentinel, m.Call());
}
#if V8_TARGET_ARCH_64_BIT
TEST(Regression12330) {
FLAG_SCOPE(turbo_force_mid_tier_regalloc);
RawMachineAssemblerTester<int32_t> m(MachineType::Int64());
Node* add = m.Int64SubWithOverflow(m.Int64Constant(0), m.Parameter(0));
Node* ovf = m.Projection(1, add);
m.Return(ovf);
m.GenerateCode();
}
#endif // V8_TARGET_ARCH_64_BIT
} // namespace compiler
} // namespace internal
} // namespace v8