Revert "Reland "[ptr-compr][arm64] Temporarily enable pointer compression on arm64""
This reverts commitd1a4706af9
. Reason for revert: Experiment over. Original change's description: > Reland "[ptr-compr][arm64] Temporarily enable pointer compression on arm64" > > This is a reland off5611402f7
> > Original change's description: > > [ptr-compr][arm64] Temporarily enable pointer compression on arm64 > > > > ... and make sure that the arm64 ptr-compr bots proceed testing V8 without > > pointer compression in order to keep testing the other config. > > > > Commented out the 'extra' variant since it was crashing. Opened a bug > > regarding that: https://bugs.chromium.org/p/v8/issues/detail?id=9568 > > > > Similar to x64's https://chromium-review.googlesource.com/c/v8/v8/+/1607654 > > > > Bug: v8:7703 > > Change-Id: Ifd46b029bab34524f9f536dcdbd1574f2ddcbf37 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724216 > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#63019} > > Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng > Bug: v8:7703 > Change-Id: I1a82b87bf6db4e6d100aeffc29dae60ba73d8119 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730998 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63043} TBR=machenbach@chromium.org,tmrts@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703 Change-Id: I86a801d44ad4ea14b1388ad8ca6109cc8a57a7d7 Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1746470 Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#63148}
This commit is contained in:
parent
fa997a3ad3
commit
28db971387
6
BUILD.gn
6
BUILD.gn
@ -107,7 +107,7 @@ declare_args() {
|
||||
v8_enable_verify_csa = false
|
||||
|
||||
# Enable pointer compression (sets -dV8_COMPRESS_POINTERS).
|
||||
v8_enable_pointer_compression = ""
|
||||
v8_enable_pointer_compression = false
|
||||
v8_enable_31bit_smis_on_64bit_arch = false
|
||||
|
||||
# Sets -dOBJECT_PRINT.
|
||||
@ -230,10 +230,6 @@ if (v8_check_microtasks_scopes_consistency == "") {
|
||||
if (v8_enable_snapshot_native_code_counters == "") {
|
||||
v8_enable_snapshot_native_code_counters = v8_enable_debugging_features
|
||||
}
|
||||
if (v8_enable_pointer_compression == "") {
|
||||
# TODO(v8:v7703): temporarily enable pointer compression on arm64
|
||||
v8_enable_pointer_compression = v8_current_cpu == "arm64"
|
||||
}
|
||||
if (v8_enable_shared_ro_heap == "") {
|
||||
v8_enable_shared_ro_heap = !v8_enable_pointer_compression && v8_use_snapshot
|
||||
}
|
||||
|
@ -369,11 +369,8 @@
|
||||
'release_simulate_arm64': [
|
||||
'release_bot', 'simulate_arm64'],
|
||||
'release_simulate_arm64_pointer_compression': [
|
||||
# TODO(v8:v7703): Make pointer compression bots testing non pointer
|
||||
# compression mode while pointer compression is temporarily enabled
|
||||
# on arm64
|
||||
'release_bot', 'simulate_arm64', 'dcheck_always_on',
|
||||
'v8_enable_slow_dchecks', 'v8_disable_pointer_compression'],
|
||||
'v8_enable_slow_dchecks', 'v8_enable_pointer_compression'],
|
||||
'release_simulate_arm64_msan': [
|
||||
'release_bot', 'simulate_arm64', 'msan'],
|
||||
'release_simulate_arm64_msan_minimal_symbols': [
|
||||
@ -822,10 +819,6 @@
|
||||
'gn_args': 'v8_enable_pointer_compression=true',
|
||||
},
|
||||
|
||||
'v8_disable_pointer_compression': {
|
||||
'gn_args': 'v8_enable_pointer_compression=false',
|
||||
},
|
||||
|
||||
'v8_enable_test_features': {
|
||||
'gn_args': 'v8_enable_test_features=true',
|
||||
},
|
||||
|
@ -790,6 +790,7 @@
|
||||
'icu-date-lord-howe': [SKIP],
|
||||
'regress/regress-6288': [SKIP],
|
||||
# OOM:
|
||||
'regress/regress-748069': [FAIL],
|
||||
'regress/regress-752764': [FAIL],
|
||||
# Flaky OOM:
|
||||
'regress/regress-779407': [SKIP],
|
||||
|
Loading…
Reference in New Issue
Block a user