AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix for .bind regression.

Browse Source 
R=jkummerow@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7892013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
rossberg@chromium.org 2011-09-13 17:14:39 +00:00
parent 321bfc549f
commit 28f7136ced
2 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/execution.cc
View File

@ -161,10 +161,11 @@ Handle<Object> Execution::Call(Handle<Object> callable,
if (convert_receiver && !receiver->IsJSReceiver() &&
!func->shared()->native() && !func->shared()->strict_mode()) {
if (receiver->IsUndefined() || receiver->IsNull()) {
// Careful, func->context()->global()->global_receiver() gives
// the JSBuiltinsObject if func is a builtin. Not what we want here.
receiver =
Handle<Object>(func->GetIsolate()->global()->global_receiver());
Object* global = func->context()->global()->global_receiver();
// For reasons that escape me, 'global' can be the JSBuiltinsObject
// under some circumstances. In that case, don't rewrite.
// FWIW, the same holds for GetIsolate()->global()->global_receiver().
if (!global->IsJSBuiltinsObject()) receiver = Handle<Object>(global);
} else {
receiver = ToObject(receiver, pending_exception);
}

17
test/mjsunit/regress/regress-bind-receiver.js Normal file
View File

@ -0,0 +1,17 @@
function strict() { 'use strict'; return this; }
function lenient() { return this; }
var obj = {};
assertEquals(true, strict.bind(true)());
assertEquals(42, strict.bind(42)());
assertEquals("", strict.bind("")());
assertEquals(null, strict.bind(null)()l);
assertEquals(undefined, strict.bind(undefined)());
assertEquals(obj, strict.bind(obj)());
assertEquals(true, lenient.bind(true)() instanceof Boolean);
assertEquals(true, lenient.bind(42)() instanceof Number);
assertEquals(true, lenient.bind("")() instanceof String);
assertEquals(this, lenient.bind(null)());
assertEquals(this, lenient.bind(undefined)());
assertEquals(obj, lenient.bind(obj)());