AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove unnecessary calls to FillFixedArrayWithSmiZero

Browse Source 
The functionality of "FillFixedArrayWithSmiZero" got merged into
"AllocateZeroedFixedArray", making these calls superfluous.

R=jgruber@chromium.org

Bug: v8:8015
Change-Id: I5453ea4b16a1446717517fe1676d611d987ad0a3
Reviewed-on: https://chromium-review.googlesource.com/1212842
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#55699}
This commit is contained in:
Simon Zünd 2018-09-07 08:35:39 +02:00 committed by Commit Bot
parent 73fc6f816c
commit 292c3ed774
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
third_party/v8/builtins/array-sort.tq vendored
View File

@ -464,7 +464,6 @@ module array {
const temp_array: FixedArray =
AllocateZeroedFixedArray(convert<intptr>(min_size));
FillFixedArrayWithSmiZero(temp_array, min_size);
sortState[kTempArraySizeIdx] = min_size;
sortState[kTempArrayIdx] = temp_array;
@ -1633,7 +1632,6 @@ module array {
SetPendingRunsSize(sortState, 0);
let pending_runs: FixedArray =
AllocateZeroedFixedArray(convert<intptr>(kMaxMergePending));
FillFixedArrayWithSmiZero(pending_runs, kMaxMergePending);
sortState[kPendingRunsIdx] = pending_runs;
}
@ -1727,7 +1725,6 @@ module array {
// array and move the undefineds after that. Holes are removed.
// This happens for Array as well as non-Array objects.
extern runtime PrepareElementsForSort(Context, Object, Number): Smi;
extern macro FillFixedArrayWithSmiZero(FixedArray, Smi);
// https://tc39.github.io/ecma262/#sec-array.prototype.sort
javascript builtin ArrayPrototypeSort(
@ -1743,9 +1740,7 @@ module array {
const obj: JSReceiver = ToObject(context, receiver);
let map: Map = obj.map;
const sort_state: FixedArray =
AllocateZeroedFixedArray(kSortStateSize);
FillFixedArrayWithSmiZero(sort_state, SmiTag(kSortStateSize));
const sort_state: FixedArray = AllocateZeroedFixedArray(kSortStateSize);
sort_state[kReceiverIdx] = obj;
sort_state[kUserCmpFnIdx] = comparefnObj;