From 298fb68368b7e60c73ce3154e8f46584702ced37 Mon Sep 17 00:00:00 2001 From: Sami Kyostila Date: Wed, 9 Jan 2019 11:47:13 +0000 Subject: [PATCH] v8: Remove trace event category warming MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since all categories are now statically defined, there's no need to warm any of them up explicitly in order for the categories to show up in the tracing UI. Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1401273. Bug: chromium:914579 Change-Id: I8ae8977130ae89d6ee3351194ad258d13f3c14f4 Reviewed-on: https://chromium-review.googlesource.com/c/1402779 Reviewed-by: Alexei Filippov Reviewed-by: Yang Guo Commit-Queue: Sami Kyöstilä Cr-Commit-Position: refs/heads/master@{#58699} --- src/profiler/tracing-cpu-profiler.cc | 4 ---- src/tracing/tracing-category-observer.cc | 5 ----- 2 files changed, 9 deletions(-) diff --git a/src/profiler/tracing-cpu-profiler.cc b/src/profiler/tracing-cpu-profiler.cc index 9662753676..0cb502bdf1 100644 --- a/src/profiler/tracing-cpu-profiler.cc +++ b/src/profiler/tracing-cpu-profiler.cc @@ -13,10 +13,6 @@ namespace internal { TracingCpuProfilerImpl::TracingCpuProfilerImpl(Isolate* isolate) : isolate_(isolate), profiling_enabled_(false) { - // Make sure tracing system notices profiler categories. - TRACE_EVENT_WARMUP_CATEGORY(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profiler")); - TRACE_EVENT_WARMUP_CATEGORY( - TRACE_DISABLED_BY_DEFAULT("v8.cpu_profiler.hires")); V8::GetCurrentPlatform()->GetTracingController()->AddTraceStateObserver(this); } diff --git a/src/tracing/tracing-category-observer.cc b/src/tracing/tracing-category-observer.cc index 28c107d88f..7fb8ee329a 100644 --- a/src/tracing/tracing-category-observer.cc +++ b/src/tracing/tracing-category-observer.cc @@ -19,11 +19,6 @@ void TracingCategoryObserver::SetUp() { v8::internal::V8::GetCurrentPlatform() ->GetTracingController() ->AddTraceStateObserver(TracingCategoryObserver::instance_); - TRACE_EVENT_WARMUP_CATEGORY(TRACE_DISABLED_BY_DEFAULT("v8.runtime_stats")); - TRACE_EVENT_WARMUP_CATEGORY( - TRACE_DISABLED_BY_DEFAULT("v8.runtime_stats_sampling")); - TRACE_EVENT_WARMUP_CATEGORY(TRACE_DISABLED_BY_DEFAULT("v8.gc_stats")); - TRACE_EVENT_WARMUP_CATEGORY(TRACE_DISABLED_BY_DEFAULT("v8.ic_stats")); } void TracingCategoryObserver::TearDown() {