AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Reland "Enable lazy feedback allocation""

Browse Source 
This reverts commit 333615cfc2.

Reason for revert: Likely culprit for browser_tests netinfo/gc-unused-listeners.html failure for "Win10 Tests x64".

Original change's description:
> Reland "Enable lazy feedback allocation"
> 
> This is a reland of 8c10501be5.
> Reland after fixing test failures.
> 
> Original change's description:
> > Enable lazy feedback allocation
> >
> > Bug: v8:8394
> > Change-Id: I29ffd38725bdcaa9dd11221045dba681eb0d567b
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643430
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Commit-Queue: Mythri Alle <mythria@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#61991}
> 
> Bug: v8:8394
> Change-Id: Icc9e276ab22ca6455b775f3c27e0d43c3f08b887
> TBR: rmcilroy@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647161
> Reviewed-by: Mythri Alle <mythria@chromium.org>
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#62018}

TBR=rmcilroy@chromium.org,mythria@chromium.org,delphick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:8394
Change-Id: Id977275f4d53a39c2372f289f2b0471efae241b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1650275
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62069}
This commit is contained in:
Samuel Huang 2019-06-10 00:28:12 +00:00 committed by Commit Bot
parent 5d0880de50
commit 29a40cac8e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/flags/flag-definitions.h
View File

@ -388,7 +388,8 @@ DEFINE_BOOL(use_ic, true, "use inline caching")
DEFINE_INT(budget_for_feedback_vector_allocation, 1 * KB, DEFINE_INT(budget_for_feedback_vector_allocation, 1 * KB,
"The budget in amount of bytecode executed by a function before we " "The budget in amount of bytecode executed by a function before we "
"decide to allocate feedback vectors") "decide to allocate feedback vectors")
DEFINE_BOOL(lazy_feedback_allocation, true, "Allocate feedback vectors lazily") DEFINE_BOOL(lazy_feedback_allocation, false, "Allocate feedback vectors lazily")
DEFINE_IMPLICATION(future, lazy_feedback_allocation)
// Flags for Ignition. // Flags for Ignition.
DEFINE_BOOL(ignition_elide_noneffectful_bytecodes, true, DEFINE_BOOL(ignition_elide_noneffectful_bytecodes, true,