AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fixed bug in array filter and reduce functions.

Browse Source 
R=danno@chromium.org
BUG=v8:1559
TEST=test262

Review URL: http://codereview.chromium.org/7368005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8661 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
mstarzinger@chromium.org 2011-07-15 11:07:18 +00:00
parent 75a2c49c1d
commit 2a225a3717
2 changed files with 3 additions and 87 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/array.js
View File

@ -999,7 +999,7 @@ function ArrayFilter(f, receiver) {
} }
// Pull out the length so that modifications to the length in the // Pull out the length so that modifications to the length in the
// loop will not affect the looping. // loop will not affect the looping.
var length = this.length; var length = ToUint32(this.length);
var result = []; var result = [];
var result_length = 0; var result_length = 0;
for (var i = 0; i < length; i++) { for (var i = 0; i < length; i++) {
@ -1236,7 +1236,7 @@ function ArrayReduce(callback, current) {
} }
// Pull out the length so that modifications to the length in the // Pull out the length so that modifications to the length in the
// loop will not affect the looping. // loop will not affect the looping.
var length = this.length; var length = ToUint32(this.length);
var i = 0; var i = 0;
find_initial: if (%_ArgumentsLength() < 2) { find_initial: if (%_ArgumentsLength() < 2) {
@ -1268,7 +1268,7 @@ function ArrayReduceRight(callback, current) {
if (!IS_FUNCTION(callback)) { if (!IS_FUNCTION(callback)) {
throw MakeTypeError('called_non_callable', [callback]); throw MakeTypeError('called_non_callable', [callback]);
} }
var i = this.length - 1; var i = ToUint32(this.length) - 1;
find_initial: if (%_ArgumentsLength() < 2) { find_initial: if (%_ArgumentsLength() < 2) {
for (; i >= 0; i--) { for (; i >= 0; i--) {

84
test/test262/test262.status
View File

@ -1138,33 +1138,6 @@ prefix ietestcenter
15.4.4.20-1-5: FAIL 15.4.4.20-1-5: FAIL
# Bug? Array.prototype.filter applied to string primitive # Bug? Array.prototype.filter applied to string primitive
15.4.4.20-1-7: FAIL 15.4.4.20-1-7: FAIL
# Bug? Array.prototype.filter - value of 'length' is a number (value is
# negative)
15.4.4.20-3-7: FAIL
# Bug? Array.prototype.filter - value of 'length' is a number (value is
# Infinity)
# V8 timeout
15.4.4.20-3-8: SKIP
# Bug? Array.prototype.filter - 'length' is a string containing a negative
# number
15.4.4.20-3-12: FAIL
# Bug? Array.prototype.filter - 'length' is a string containing a decimal number
15.4.4.20-3-13: FAIL
# Bug? Array.prototype.filter - 'length' is a string containing +/-Infinity
15.4.4.20-3-14: SKIP
# Bug? Array.prototype.filter - value of 'length' is a positive non-integer,
# ensure truncation occurs in the proper direction
# V8 timeout
15.4.4.20-3-24: FAIL
# Bug? Array.prototype.filter - value of 'length' is a negative non-integer,
# ensure truncation occurs in the proper direction
15.4.4.20-3-25: FAIL
# Bug? Array.prototype.filter - value of 'length' is boundary value (2^32)
# V8 timeout
15.4.4.20-3-28: SKIP
# Bug? Array.prototype.filter - value of 'length' is boundary value (2^32 + 1)
# V8 timeout
15.4.4.20-3-29: SKIP
# Bug? Array.prototype.filter - side effects produced by step 2 are visible when # Bug? Array.prototype.filter - side effects produced by step 2 are visible when
# an exception occurs # an exception occurs
15.4.4.20-4-8: FAIL 15.4.4.20-4-8: FAIL
@ -1220,33 +1193,6 @@ prefix ietestcenter
15.4.4.21-1-5: FAIL 15.4.4.21-1-5: FAIL
# Bug? Array.prototype.reduce applied to string primitive # Bug? Array.prototype.reduce applied to string primitive
15.4.4.21-1-7: FAIL 15.4.4.21-1-7: FAIL
# Bug? Array.prototype.reduce - value of 'length' is a number (value is
# negative)
15.4.4.21-3-7: FAIL
# Bug? Array.prototype.reduce - value of 'length' is a number (value is
# Infinity)
# V8 timeout.
15.4.4.21-3-8: SKIP
# Bug? Array.prototype.reduce - 'length' is a string containing a negative
# number
15.4.4.21-3-12: FAIL
# Bug? Array.prototype.reduce - 'length' is a string containing a decimal number
15.4.4.21-3-13: FAIL
# Bug? Array.prototype.reduce - 'length' is a string containing +/-Infinity
# V8 timeout.
15.4.4.21-3-14: SKIP
# Bug? Array.prototype.reduce - value of 'length' is a positive non-integer,
# ensure truncation occurs in the proper direction
15.4.4.21-3-24: FAIL
# Bug? Array.prototype.reduce - value of 'length' is a negative non-integer,
# ensure truncation occurs in the proper direction
15.4.4.21-3-25: FAIL
# Bug? Array.prototype.reduce - value of 'length' is boundary value (2^32)
# V8 timeout.
15.4.4.21-3-28: SKIP
# Bug? Array.prototype.reduce - value of 'length' is boundary value (2^32 + 1)
# V8 timeout.
15.4.4.21-3-29: SKIP
# Bug? Array.prototype.reduce - side effects produced by step 2 are visible when # Bug? Array.prototype.reduce - side effects produced by step 2 are visible when
# an exception occurs # an exception occurs
15.4.4.21-4-8: FAIL 15.4.4.21-4-8: FAIL
@ -1274,36 +1220,6 @@ prefix ietestcenter
15.4.4.22-1-5: FAIL 15.4.4.22-1-5: FAIL
# Bug? Array.prototype.reduceRight applied to string primitive # Bug? Array.prototype.reduceRight applied to string primitive
15.4.4.22-1-7: FAIL 15.4.4.22-1-7: FAIL
# Bug? Array.prototype.reduceRight - value of 'length' is a number (value is
# negative)
15.4.4.22-3-7: FAIL
# Bug? Array.prototype.reduceRight - value of 'length' is a number (value is
# Infinity)
# V8 timeout.
15.4.4.22-3-8: SKIP
# Bug? Array.prototype.reduceRight - value of 'length' is a string containing a
# negative number
15.4.4.22-3-12: FAIL
# Bug? Array.prototype.reduceRight - value of 'length' is a string containing a
# decimal number
15.4.4.22-3-13: FAIL
# Bug? Array.prototype.reduceRight - value of 'length' is a string containing
# +/-Infinity
# V8 timeout.
15.4.4.22-3-14: SKIP
# Bug? Array.prototype.reduceRight - value of 'length' is a positive
# non-integer, ensure truncation occurs in the proper direction
15.4.4.22-3-24: FAIL
# Bug? Array.prototype.reduceRight - value of 'length' is a negative
# non-integer, ensure truncation occurs in the proper direction
15.4.4.22-3-25: FAIL
# Bug? Array.prototype.reduceRight - value of 'length' is boundary value (2^32)
# V8 timeout.
15.4.4.22-3-28: SKIP
# Bug? Array.prototype.reduceRight - value of 'length' is boundary value (2^32 +
# 1)
# V8 timeout.
15.4.4.22-3-29: SKIP
# Bug? Array.prototype.reduceRight - side effects produced by step 2 are visible # Bug? Array.prototype.reduceRight - side effects produced by step 2 are visible
# when an exception occurs # when an exception occurs
15.4.4.22-4-8: FAIL 15.4.4.22-4-8: FAIL