AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Fix SIMD register overlap check

Browse Source 
We should only check the "SIMD sibling" register if we are handling a
SIMD register. This avoids unneeded spills, and in this particular case
ran into a DCHECK because there are only 29 registers, but we tried
checking #29.

R=thibaudm@chromium.org

Bug: v8:12330, v8:1285007
Change-Id: Ife8b295ac958990611ca8816bbfbfb5124a4297d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372916
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78532}
This commit is contained in:
Clemens Backes 2022-01-08 11:10:47 +01:00 committed by V8 LUCI CQ
parent b4870d2822
commit 2a7f160233
2 changed files with 44 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/compiler/backend/mid-tier-register-allocator.cc
View File

@ -1763,9 +1763,10 @@ void SinglePassRegisterAllocator::MergeStateFrom(
if (processed_regs.Contains(reg, rep)) continue;
processed_regs.Add(reg, rep);
bool reg_in_use = register_state_->IsAllocated(reg) ||
(!kSimpleFPAliasing &&
register_state_->IsAllocated(reg.simdSibling()));
bool reg_in_use =
register_state_->IsAllocated(reg) ||
(!kSimpleFPAliasing && rep == MachineRepresentation::kSimd128 &&
register_state_->IsAllocated(reg.simdSibling()));
if (!reg_in_use) {
DCHECK(successor_registers->IsAllocated(reg));

40
test/mjsunit/regress/regress-1285007.js Normal file
View File

@ -0,0 +1,40 @@
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --assert-types --interrupt-budget=1000
// Flags: --no-lazy-feedback-allocation --turboprop
var __v_12 = [];
var __v_30 = {};
function __f_0(x, len) {
var __v_1 = new Array();
var __v_2 = x + 0.5;
var __v_3 = x + 1.5;
var __v_4 = x + 2.5;
var __v_5 = x + 3.5;
var __v_7 = x + 5.5;
var __v_15 = x + 13.5;
var __v_16 = x + 14.5;
var __v_22 = x + 20.5;
var __v_25 = x + 23.5;
var __v_8 = x + 24.5;
__v_12[len] = 0;
__v_1[0] = __v_2;
__v_1[1] = __v_3;
__v_1[2] = __v_4;
__v_1[3] = __v_5;
__v_1 = __v_30;
__v_1[5] = __v_7;
__v_1[6] = __v_8;
__v_1[13] = __v_15;
__v_1[14] = __v_16;
__v_1[23] = __v_25;
for (var __v_27 = 0; __v_27 < __v_1.length; __v_27++) {
x + __v_22 + [__v_37];
}
}
%PrepareFunctionForOptimization(__f_0);
__f_0();
%OptimizeFunctionOnNextCall(__f_0);
__f_0();