AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

MIPS: Improve '[es6] When comparing two symbols we may need to throw a TypeError'.

Browse Source 
Improve d26f5d3923

Original commit message:
When comparing a symbol to istself using <, <=, > or >= we need to
throw a TypeError. This is correctly handled in the runtime function
so if we are comparing a symbol fall back to use the runtime.

BUG=

Review URL: https://codereview.chromium.org/1124863004

Cr-Commit-Position: refs/heads/master@{#28240}
This commit is contained in:
balazs.kilvady 2015-05-05 11:50:52 -07:00 committed by Commit bot
parent 38f7ccba79
commit 2a86d26f33
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mips/code-stubs-mips.cc
View File

@ -294,7 +294,6 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm,
if (cc == less || cc == greater) {
__ GetObjectType(a0, t4, t4);
__ Branch(slow, greater, t4, Operand(FIRST_SPEC_OBJECT_TYPE));
__ GetObjectType(a0, t4, t4);
__ Branch(slow, eq, t4, Operand(SYMBOL_TYPE));
} else {
__ GetObjectType(a0, t4, t4);

1
src/mips64/code-stubs-mips64.cc
View File

@ -290,7 +290,6 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm,
if (cc == less || cc == greater) {
__ GetObjectType(a0, t0, t0);
__ Branch(slow, greater, t0, Operand(FIRST_SPEC_OBJECT_TYPE));
__ GetObjectType(a0, t0, t0);
__ Branch(slow, eq, t0, Operand(SYMBOL_TYPE));
} else {
__ GetObjectType(a0, t0, t0);