AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove unused AllocationSpace paramenter from CollectGarbage.

Browse Source 
BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/148943004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19054 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
hpayer@chromium.org 2014-02-04 10:30:36 +00:00
parent f62ef25c08
commit 2afcfc0b0e
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/heap-inl.h
View File

@ -555,8 +555,7 @@ bool Heap::CollectGarbage(AllocationSpace space,
const v8::GCCallbackFlags callbackFlags) { const v8::GCCallbackFlags callbackFlags) {
const char* collector_reason = NULL; const char* collector_reason = NULL;
GarbageCollector collector = SelectGarbageCollector(space, &collector_reason); GarbageCollector collector = SelectGarbageCollector(space, &collector_reason);
return CollectGarbage( return CollectGarbage(collector, gc_reason, collector_reason, callbackFlags);
space, collector, gc_reason, collector_reason, callbackFlags);
} }

5
src/heap.cc
View File

@ -739,7 +739,7 @@ void Heap::CollectAllAvailableGarbage(const char* gc_reason) {
const int kMaxNumberOfAttempts = 7; const int kMaxNumberOfAttempts = 7;
const int kMinNumberOfAttempts = 2; const int kMinNumberOfAttempts = 2;
for (int attempt = 0; attempt < kMaxNumberOfAttempts; attempt++) { for (int attempt = 0; attempt < kMaxNumberOfAttempts; attempt++) {
if (!CollectGarbage(OLD_POINTER_SPACE, MARK_COMPACTOR, gc_reason, NULL) && if (!CollectGarbage(MARK_COMPACTOR, gc_reason, NULL) &&
attempt + 1 >= kMinNumberOfAttempts) { attempt + 1 >= kMinNumberOfAttempts) {
break; break;
} }
@ -751,8 +751,7 @@ void Heap::CollectAllAvailableGarbage(const char* gc_reason) {
} }
bool Heap::CollectGarbage(AllocationSpace space, bool Heap::CollectGarbage(GarbageCollector collector,
GarbageCollector collector,
const char* gc_reason, const char* gc_reason,
const char* collector_reason, const char* collector_reason,
const v8::GCCallbackFlags gc_callback_flags) { const v8::GCCallbackFlags gc_callback_flags) {

1
src/heap.h
View File

@ -2123,7 +2123,6 @@ class Heap {
// Returns whether there is a chance that another major GC could // Returns whether there is a chance that another major GC could
// collect more garbage. // collect more garbage.
bool CollectGarbage( bool CollectGarbage(
AllocationSpace space,
GarbageCollector collector, GarbageCollector collector,
const char* gc_reason, const char* gc_reason,
const char* collector_reason, const char* collector_reason,